-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_mitgcm
test failing with new dask release
#1762
Comments
This has to do with the Parcels/docs/examples/example_dask_chunk_OCMs.py Lines 564 to 567 in eb97b32
|
Yeah, I'm struggling to understand what the test (and underlying fieldfilebuffer.py) is doing. The fact that we have failure here: if chunk_mode != "specific_different":
assert len(fieldset.U.grid._load_chunk) == len(fieldset.V.grid._load_chunk) leads me to think that when using auto chunking that for some reason the U and V grids don't have the same number of chunks. Not sure what the implications of that are though. @erikvansebille any immediate ideas how do you think we could relax the tests? I think these tests could do with a refactor down the line. xref #853 |
Yes, a refactor would be good down the line; also when we get uxarray-support in Parcels v4? But until then, perhaps we can just |
docs/examples/example_dask_chunk_OCMs.py::test_mitgcm
has been failing in CI this week with the release of daskv2024.11.0
.Downgrading to v2024.10.0 fixes the error, but it would be good to investigate and patch the test.
The text was updated successfully, but these errors were encountered: