Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Misleading checkbox "Enable unsafe levels" on page "Get Started" #712

Open
rudosch opened this issue Nov 10, 2022 · 0 comments
Open
Labels

Comments

@rudosch
Copy link
Contributor

rudosch commented Nov 10, 2022

IMHO, the checkbox "Enable unsafe levels" on the Get Started page is misleading, because it is effective for the buttons on this page only.
If you (like I did) first close all modules and then open single categories in OpenFloor mode, then e.g. for the category "Injection" also the unsafe XXE modules are opened without being warned. Not knowing how the lessons/challenges are implemented (simulation or for real), it is impossible to estimate if they are safe or not.

Therefore my suggestions :

  • the decision about unsafe modules should be memorized in table core.settings
  • the checkbox should also be present on pages Open/Close Modules and Open/Close Categories; depending on it unsafe modules could be listed or not (in case of Open/Close Modules) or not opened (in case of Open/Close Categories).
  • unsafe modules in module listings could be marked with a star at the end of their names

BTW: there's a Discussions tab here in GitHub. I wanted to present these considerations there first, but it seems the discussion section is not (yet) used in this project.

@rudosch rudosch added the Bug label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant