Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code to make sure os path related logic is OS agnostic #933

Open
arkid15r opened this issue Oct 1, 2024 · 15 comments
Open

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Oct 1, 2024

Refactor the code to make the code expecting Unix/Linux paths OS-independent.
Test and ensure that the the entire application with all its functionality (including Scan engine, API and WebUI) works equally fine on both Windows and Unix-like operating systems

@arkid15r arkid15r self-assigned this Oct 1, 2024
@arkid15r arkid15r removed their assignment Dec 4, 2024
@winters0x64
Copy link
Contributor

Hi, I'd like to work on this issue, could you assign it to me?

@bhagyashree980
Copy link
Contributor

Hi @arkid15r ,

I noticed that issue #933: Refactor the code to make sure os path related logic is OS agnostic #933 is currently assigned but hasn’t had any recent activity in the last two weeks. I’m eager to contribute and would love to help move this forward.
If the current assignee is unavailable or needs assistance, I would be happy to take over or collaborate to resolve this issue promptly. Please let me know how I can assist.
Looking forward to your response!

@winters0x64
Copy link
Contributor

I'm still working on this, just wanted to make sure everything is working before i send the final PR.

@bhagyashree980
Copy link
Contributor

@winters0x64 Thank you for your update

@winters0x64
Copy link
Contributor

@bhagyashree980 , appreciate you looking into this, I was occupied with implementing some security checks, that's why this got delayed. If you want to contribute you can try to improve the nettacker engine part, I'll be looking at that after this maybe we can collaborate on that.

@bhagyashree980
Copy link
Contributor

Hi @winters0x64 ,
Thank you for the update and for sharing the context. I understand how implementing security checks can take priority. I appreciate the suggestion to look into improving the Nettacker engine part—I'll start exploring it right away.

@vishakha-mali
Copy link

It's been a month for the previous user,Can I get the chance?

@winters0x64
Copy link
Contributor

@vishakha-mali , I appreciate your interest in the issue but I'm still resolving this issue with @arkid15r , my PR is almost complete, just testing all the edge cases that might arise due to cross platform compatibility issues.

@vishakha-mali
Copy link

Yeah sure, I thought you were not active.I just wanted to give a try as I am a beginner.

@winters0x64
Copy link
Contributor

@vishakha-mali , I encourage you to still try to fix this issue, collective efforts make the project better, you'll also learn a lot. Feel free to ask any doubts if you have I'd be happy to help, all the best :)

@pUrGe12
Copy link
Contributor

pUrGe12 commented Feb 3, 2025

@winters0x64 are you planning to migrate the dockerfile to also work on windows or only the paths? Cause I had tried running this on my windows machine a few days back and with a some changes it works well, so lemme know what you're planning and we can work on this together?

@winters0x64
Copy link
Contributor

@pUrGe12 I was not planning to migrate the Dockerfile to support windows as well, only going for the paths right now, afaik it'll work on windows machine right now but if it affects upgradeability, as in future the path could become an issue so its better to use the proper paths for the respective OS. Sure we can work on this togethter, hmu.

@SumraShahzadi
Copy link

As a beginner in open source contribution ,I want to try to resolve this issue and I am working on it

@Manushya-a
Copy link
Contributor

hey @SumraShahzadi I wanted to ask if you were working on this issue or if i could jump on this one?

@SumraShahzadi
Copy link

SumraShahzadi commented Mar 17, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants