-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the code to make sure os path related logic is OS agnostic #933
Comments
Hi, I'd like to work on this issue, could you assign it to me? |
Hi @arkid15r , I noticed that issue #933: Refactor the code to make sure os path related logic is OS agnostic #933 is currently assigned but hasn’t had any recent activity in the last two weeks. I’m eager to contribute and would love to help move this forward. |
I'm still working on this, just wanted to make sure everything is working before i send the final PR. |
@winters0x64 Thank you for your update |
@bhagyashree980 , appreciate you looking into this, I was occupied with implementing some security checks, that's why this got delayed. If you want to contribute you can try to improve the nettacker engine part, I'll be looking at that after this maybe we can collaborate on that. |
Hi @winters0x64 , |
It's been a month for the previous user,Can I get the chance? |
@vishakha-mali , I appreciate your interest in the issue but I'm still resolving this issue with @arkid15r , my PR is almost complete, just testing all the edge cases that might arise due to cross platform compatibility issues. |
Yeah sure, I thought you were not active.I just wanted to give a try as I am a beginner. |
@vishakha-mali , I encourage you to still try to fix this issue, collective efforts make the project better, you'll also learn a lot. Feel free to ask any doubts if you have I'd be happy to help, all the best :) |
@winters0x64 are you planning to migrate the dockerfile to also work on windows or only the paths? Cause I had tried running this on my windows machine a few days back and with a some changes it works well, so lemme know what you're planning and we can work on this together? |
@pUrGe12 I was not planning to migrate the Dockerfile to support windows as well, only going for the paths right now, afaik it'll work on windows machine right now but if it affects upgradeability, as in future the path could become an issue so its better to use the proper paths for the respective OS. Sure we can work on this togethter, hmu. |
As a beginner in open source contribution ,I want to try to resolve this issue and I am working on it |
hey @SumraShahzadi I wanted to ask if you were working on this issue or if i could jump on this one? |
yes ,you can
…On Sun, Mar 16, 2025 at 10:12 PM Manav Acharya ***@***.***> wrote:
hey @SumraShahzadi <https://github.com/SumraShahzadi> I wanted to ask if
you were working on this issue or if i could jump on this one?
—
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNRYZBSUHXQXTRW2IJASQVD2UZKVLAVCNFSM6AAAAABPF6UU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRYGE4DQNBZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: Manushya-a]*Manushya-a* left a comment (OWASP/Nettacker#933)
<#933 (comment)>
hey @SumraShahzadi <https://github.com/SumraShahzadi> I wanted to ask if
you were working on this issue or if i could jump on this one?
—
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNRYZBSUHXQXTRW2IJASQVD2UZKVLAVCNFSM6AAAAABPF6UU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRYGE4DQNBZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Refactor the code to make the code expecting Unix/Linux paths OS-independent.
Test and ensure that the the entire application with all its functionality (including Scan engine, API and WebUI) works equally fine on both Windows and Unix-like operating systems
The text was updated successfully, but these errors were encountered: