Skip to content

Make header buttons look consistent #1608

@arkid15r

Description

@arkid15r
Collaborator

Describe the bug

The Star and Sponsor buttons have a bit different padding and look inconsistently.

To Reproduce

https://nest.owasp.org/

Expected behavior
The buttons should look consistent.

Perhaps we should create a new component for this set of buttons and reuse it.

Are you going to work on fixing this?

  • Yes
    No

Screenshots

Image

Activity

YakshitAgarwal

YakshitAgarwal commented on Jun 14, 2025

@YakshitAgarwal
Contributor

Hello, I would like to work on this issue. I will correct the styling of the buttons to make them look consistent.
ETA: 1 hour

arkid15r

arkid15r commented on Jun 14, 2025

@arkid15r
CollaboratorAuthor

@YakshitAgarwal no rush, however we want to introduce a shared component as we're going to have another similar button soon (for GitHub sign in).

moved this from Backlog to In progress in Project Neston Jun 14, 2025
YakshitAgarwal

YakshitAgarwal commented on Jun 14, 2025

@YakshitAgarwal
Contributor

Sure once the button has been added then I work on them all together.

arkid15r

arkid15r commented on Jun 14, 2025

@arkid15r
CollaboratorAuthor

Sure once the button has been added then I work on them all together.

It's already there just in a feature branch. Feel free to work on the existing buttons and let other contributors re-use the button component as needed.

arkid15r

arkid15r commented on Jun 26, 2025

@arkid15r
CollaboratorAuthor

Resolved in #1625

moved this from In progress to Done in Project Neston Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @arkid15r@YakshitAgarwal

      Issue actions

        Make header buttons look consistent · Issue #1608 · OWASP/Nest