Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic EK80 Environment Datagrams for Replayed Files and Large Files #1386

Open
ctuguinay opened this issue Sep 3, 2024 · 0 comments
Open
Assignees
Labels
Milestone

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Sep 3, 2024

From conversation with @leewujung,

Currently, the Echopype parsing code in parse_base.py expects the EK80 Environment datagram to be unique, i.e., we only get one XML datagram with subtype environment. However, when parsing replayed files and large files (~2GiB) with EK80 application_version='23.6.2.0' and file_format_version='1.32' (the latest versions), we encounter multiple XML datagrams with subtype environment where only the first datagram contains all the environment variables we need for calibration (temp, salinity, pressure, etc.) and the latter datagrams contain only drop_keel_offset and drop_keel_offset_is_manual. The latter datagrams override the first datagram and we end up with an EchoData object that does not contain the environment parameters we need for calibration.

As a temporary fix to this, we will drop XML datagrams with subtype environment where the only data available is drop_keel_offset and drop_keel_offset_is_manual.

@leewjung update: A more thorough fix is to take in all environment datagrams and set the non-existing variables to NaN, and then ensure the downstream compute_Sv function can handle these variations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant