port: convert to safe path functions

Author: rouault

port/cpl_findfile.cpp

@@ -139,12 +139,12 @@ const char *CPLDefaultFindFile(const char *pszClass, const char *pszBasename)
 
     for (int i = nLocations - 1; i >= 0; i--)
     {
-        const char *pszResult = CPLFormFilename(
+        const std::string osResult = CPLFormFilenameSafe(
             pTLSData->papszFinderLocations[i], pszBasename, nullptr);
 
         VSIStatBufL sStat;
-        if (VSIStatL(pszResult, &sStat) == 0)
-            return pszResult;
+        if (VSIStatL(osResult.c_str(), &sStat) == 0)
+            return CPLSPrintf("%s", osResult.c_str());
     }
 
     if (EQUAL(pszClass, "gdal") && !CPLGetConfigOption("GDAL_DATA", nullptr))

port/cpl_odbc.cpp

@@ -167,11 +167,8 @@ bool CPLODBCDriverInstaller::FindMdbToolsDriverLib(CPLString &osDriverFile)
         if (VSIStat(pszDrvCfg, &sStatBuf) == 0 && VSI_ISDIR(sStatBuf.st_mode))
         {
             // Find default library in custom directory
-            const char *pszDriverFile =
-                CPLFormFilename(pszDrvCfg, "libmdbodbc.so", nullptr);
-            CPLAssert(nullptr != pszDriverFile);
-
-            strLibPath = pszDriverFile;
+            strLibPath =
+                CPLFormFilenameSafe(pszDrvCfg, "libmdbodbc.so", nullptr);
         }
 
         if (LibraryExists(strLibPath.c_str()))
@@ -216,14 +213,12 @@ bool CPLODBCDriverInstaller::FindMdbToolsDriverLib(CPLString &osDriverFile)
     {
         for (const char *pszLibName : apszLibNames)
         {
-            const char *pszDriverFile =
-                CPLFormFilename(pszPath, pszLibName, nullptr);
-            CPLAssert(nullptr != pszDriverFile);
-
-            if (LibraryExists(pszDriverFile))
+            const std::string osDriverFileAttempt =
+                CPLFormFilenameSafe(pszPath, pszLibName, nullptr);
+            if (LibraryExists(osDriverFileAttempt.c_str()))
             {
                 // Save default driver path
-                osDriverFile = pszDriverFile;
+                osDriverFile = osDriverFileAttempt;
                 return true;
             }
         }

port/cpl_vsil_s3.cpp

@@ -1787,7 +1787,7 @@ VSIVirtualHandle *VSICurlFilesystemHandlerBaseWritable::Open(
             return nullptr;
         }
 
-        const std::string osTmpFilename(CPLGenerateTempFilename(nullptr));
+        const std::string osTmpFilename(CPLGenerateTempFilenameSafe(nullptr));
         if (strchr(pszAccess, 'r'))
         {
             auto poExistingFile =