New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of nGeomHash happens twice while using existing hash files #110

Open

dhyan1272 opened this issue Sep 20, 2021 · 1 comment

dhyan1272 commented Sep 20, 2021 •

edited

Loading

The value of nGeomHash is updated here
https://github.com/ORNL-Fusion/GITR/blob/dev/src/gitr.cpp#L473
when either creating a hash file or using an existing hash file (https://github.com/ORNL-Fusion/GITR/blob/dev/src/gitr.cpp#L442) (GEOM_HASH=1 or 2)
The value of nGeomHash is updated again while using an existing hash file (GEOM_HASH=2)
https://github.com/ORNL-Fusion/GITR/blob/dev/src/gitr.cpp#L551
This updates the value twice.

In the legacy version of GITR the value of nGeomHash was updated only once while using existing hash files (GEOM_HASH=2) as the first update:
https://github.com/ORNL-Fusion/GITR_legacy/blob/master/src/gitr.cpp#L447
was avoided due to the compile time option:
https://github.com/ORNL-Fusion/GITR_legacy/blob/master/src/gitr.cpp#L417

Collaborator

stonecoldhughes commented Sep 27, 2021

We appreciate you identifying this issue. Thanks! Will notify when we have pushed a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment