Skip to content

Conversation

@bska
Copy link
Member

@bska bska commented Sep 25, 2025

The existing implementation of POW (exponentiation operator, "^") supports UDQ sets of the same size only. This commit extends this support to handle combinations of UDQ sets and UDQ scalars, e.g.,

(well level UDQ) ^ scalar
scalar ^ (group level UDQ)

@bska
Copy link
Member Author

bska commented Sep 25, 2025

jenkins build this please

@bska bska added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Sep 25, 2025
@bska
Copy link
Member Author

bska commented Sep 25, 2025

I am creating this PR in draft mode because it needs additional unit tests before it's ready for review. I will keep the PR in a draft state until such time.

@bska bska force-pushed the udq-pow-mixed-mode branch from dcbf066 to 4049971 Compare September 26, 2025 10:30
@bska
Copy link
Member Author

bska commented Sep 26, 2025

I am creating this PR in draft mode because it needs additional unit tests before it's ready for review.

I've added a set of unit tests for this function to demonstrate the capability. I'm therefore marking this PR as "ready for review" now.

@bska bska marked this pull request as ready for review September 26, 2025 10:31
@bska
Copy link
Member Author

bska commented Sep 26, 2025

jenkins build this please

The existing implementation of POW (exponentiation operator, "^")
supports UDQ sets of the same size only.  This commit extends this
support to handle combinations of UDQ sets and UDQ scalars, e.g.,

    (well level UDQ) ^ scalar
    scalar ^ (group level UDQ)
@bska bska force-pushed the udq-pow-mixed-mode branch from 4049971 to 06a5720 Compare September 29, 2025 14:11
@bska
Copy link
Member Author

bska commented Sep 29, 2025

jenkins build this please

@bska
Copy link
Member Author

bska commented Sep 30, 2025

The downstream bug fix in PR #4758 should go into the 2025.10 release so I'm tagging this work with the 2025.10 milestone to ensure that it does not get lost in the lead-up to creating the release branches.

@bska bska added this to the Release 2025.10 milestone Sep 30, 2025
@bska
Copy link
Member Author

bska commented Sep 30, 2025

PR approved and build check is green. I'll merge into master.

@bska bska merged commit a01e867 into OPM:master Sep 30, 2025
2 checks passed
@bska bska deleted the udq-pow-mixed-mode branch September 30, 2025 08:16
@daavid00 daavid00 removed this from the Release 2025.10 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants