Review fixes 2

Author: verveerpj

opm/input/eclipse/Schedule/MSW/Compsegs.cpp

@@ -370,7 +370,7 @@ namespace {
     {
         std::vector<Record> compsegs;
 
-        for (auto [startMD, endMD, ijk] : segments_md_and_ijk) {
+        for (const auto& [startMD, endMD, ijk] : segments_md_and_ijk) {
             // Defaulted values:
             auto direction = Connection::Direction::X;
             const double center_depth = 0.0;

opm/input/eclipse/Schedule/MSW/WellSegments.cpp

@@ -189,9 +189,6 @@ namespace Opm {
                                                            const std::vector<std::pair<double, double>>& lengths_and_depths,
                                                            double diameter, const UnitSystem& unit_system)
     {
-        // Only LengthDepth::ABS is supported:
-        assert (this->m_length_depth_type == WellSegments::LengthDepth::ABS);
-
         const int branchID = 1;  // Only main branch for now.
 
         const double roughness = 0.0;  // Defaulted: ROUGHNESS in WELSEGS.
@@ -242,8 +239,6 @@ namespace Opm {
         const auto nodeX_top = record1.getItem("TOP_X").getSIDouble(0);
         const auto nodeY_top = record1.getItem("TOP_Y").getSIDouble(0);
 
-        this->m_length_depth_type = length_depth_type;
-
         // The main branch is 1 instead of 0.  The segment number for top
         // segment is also 1.
         if (length_depth_type == LengthDepth::INC) {

opm/input/eclipse/Schedule/MSW/WellSegments.hpp

@@ -123,12 +123,6 @@ namespace Opm {
             serializer(m_comp_pressure_drop);
             serializer(m_segments);
             serializer(segment_number_to_index);
-            serializer(m_length_depth_type);
-        }
-        
-        LengthDepth getLengthDepthType() const 
-        {
-            return this->m_length_depth_type;
         }
 
     private:
@@ -160,9 +154,6 @@ namespace Opm {
         // the mapping from the segment number to the
         // storage index in the vector
         std::map<int, int> segment_number_to_index{};
-
-        // The length/depth type, incremental or absolute
-        LengthDepth m_length_depth_type{LengthDepth::ABS};
     };
 }
 

opm/input/eclipse/Schedule/Well/GridIndependentWellKeywordHandlers.cpp

@@ -1,5 +1,5 @@
 /*
-  Copyright 2020 Statoil ASA.
+  Copyright 2025 Equinor ASA.
 
   This file is part of the Open Porous Media project (OPM).
 
@@ -81,9 +81,9 @@ void add_segments(HandlerContext& handlerContext,
 }
 
 
-void process_connections(HandlerContext& handlerContext,
-                         const std::string& name,
-                         const std::vector<std::tuple<double, double, std::array<int, 3>>> intersections_md_and_ijk)
+void process_segment_connections(HandlerContext& handlerContext,
+                                 const std::string& name,
+                                 const std::vector<std::tuple<double, double, std::array<int, 3>>>& intersections_md_and_ijk)
 {
     auto well = handlerContext.state().wells.get(name);
     auto [new_connections, new_segments] = Compsegs::getConnectionsAndSegmentsFromTrajectory(
@@ -103,11 +103,6 @@ void process_segments(HandlerContext& handlerContext, const std::string& name,
 {
     const auto& well = handlerContext.state().wells.get(name);
     if (well.isMultiSegment()) {
-        // COMPTRAJ is in absolute units, INC in WELSEGS is not supported:
-        if (well.getSegments().getLengthDepthType() == WellSegments::LengthDepth::INC) {
-            const auto msg = fmt::format("   WELSEGS/{} defines segments as incremental (INC): only ABS allowed", name);
-            throw Opm::OpmInputError(msg, handlerContext.keyword.location());
-        }
         // For now, no segments may be defined via WELSEGS, except for the top:
         if (well.getSegments().size() > 1) {
             const auto msg = fmt::format("   {} already defines segments with the WELSEGS keyword", name);
@@ -116,7 +111,7 @@ void process_segments(HandlerContext& handlerContext, const std::string& name,
 
         auto [intersections_md_and_ijk, cell_md_and_tvd] = get_segment_geometries(handlerContext, intersections, wellPathGeometry);
         add_segments(handlerContext, name, cell_md_and_tvd, diameter);
-        process_connections(handlerContext, name, intersections_md_and_ijk);
+        process_segment_connections(handlerContext, name, intersections_md_and_ijk);
     }
 
 }

opm/input/eclipse/Schedule/Well/GridIndependentWellKeywordHandlers.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright 2020 Statoil ASA.
+  Copyright 2025 Equinor ASA.
 
   This file is part of the Open Porous Media project (OPM).
 
@@ -27,7 +27,7 @@
 
 namespace Opm {
 
-//! \brief Obtain a list of well completion keyword handlers.
+//! \brief Obtain a list of grid independent well keyword handlers.
 std::vector<std::pair<std::string,KeywordHandlers::handler_function>> getGridIndependentWellKeywordHandlers();
 
 }

opm/input/eclipse/Schedule/Well/WellCompletionKeywordHandlers.cpp

@@ -28,7 +28,6 @@
 
 #include <opm/input/eclipse/Parser/ParserKeywords/C.hpp>
 
-
 #include "../HandlerContext.hpp"
 
 #include <fmt/format.h>