Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aerosol direct scaling #170

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Fix aerosol direct scaling #170

merged 3 commits into from
Nov 23, 2024

Conversation

chrisroadmap
Copy link
Collaborator

@chrisroadmap chrisroadmap commented Nov 23, 2024

Previously, setting a scaling factor for a greenhouse gas species that also influences aerosol direct forcing also scaled that species' impact on aerosol direct forcing - this was not desired. This would only be an effect for CH4, N2O and HCs, on which the direct aerosol forcing impact is very small, which is why it was barely noticeable. Fixes #168

Please confirm that this pull request has done the following:

  • Test results updated
  • Description in CHANGELOG.rst added

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb2efd1) to head (387db6e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          817       817           
  Branches       124       124           
=========================================
  Hits           817       817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chrisroadmap chrisroadmap merged commit ce06ad5 into master Nov 23, 2024
8 checks passed
@chrisroadmap chrisroadmap deleted the fix-aer-direct-scale branch November 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forcing scale affecting forcing from Aerosol-radiation interactions
1 participant