Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http uri spaces 2881 v21 #9843

Closed
wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

@catenacyber catenacyber commented Nov 19, 2023

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #9501 with rebase and S-V test targeting 8

OISF/suricata-verify#1483

SV_BRANCH=pr/1483
LIBHTP_BRANCH=pr/408

OISF/libhtp#408

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d2b25af) 82.42% compared to head (6c094b6) 82.43%.
Report is 236 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9843   +/-   ##
=======================================
  Coverage   82.42%   82.43%           
=======================================
  Files         972      972           
  Lines      273929   273954   +25     
=======================================
+ Hits       225788   225836   +48     
+ Misses      48141    48118   -23     
Flag Coverage Δ
fuzzcorpus 64.33% <76.19%> (+0.04%) ⬆️
suricata-verify 61.08% <80.95%> (-0.01%) ⬇️
unittests 62.88% <19.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 16642

@victorjulien victorjulien added the needs rebase Needs rebase to master label Jan 26, 2024
@catenacyber
Copy link
Contributor Author

Rebased in #10301

Victor, why did you put the label as there was no conflict ? (I did not get a notification from just a label)

@catenacyber catenacyber closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
Development

Successfully merging this pull request may close these issues.

3 participants