Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applayer plugin 5053 v3.15.1 #12234

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos (also work with static constant) in all places
  • preventive fix of macro with parenthesis cc @jufajardini

Let me know if I should split this PR

#12163 first commits, just making alprotos number dynamic, and not yet adding plugins support

instead of a global variable.

For easier initialization with dynamic number of protocols
for expectation_proto

Ticket: 5053
so that we can use safely EXCEPTION_POLICY_MAX*sizeof(x)
Ticket: 5053

delay after initialization so that StringToAppProto works
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 90.52632% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (09ba69c) to head (c53a564).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12234      +/-   ##
==========================================
- Coverage   83.19%   82.45%   -0.74%     
==========================================
  Files         912      912              
  Lines      257166   257186      +20     
==========================================
- Hits       213938   212069    -1869     
- Misses      43228    45117    +1889     
Flag Coverage Δ
fuzzcorpus 60.40% <80.42%> (-0.61%) ⬇️
livemode 19.41% <69.31%> (+<0.01%) ⬆️
pcap 44.40% <84.12%> (+<0.01%) ⬆️
suricata-verify 62.77% <90.47%> (-0.02%) ⬇️
unittests 58.12% <68.94%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.dcerpc_tcp 40 42 105.0%

Pipeline 23707

@victorjulien
Copy link
Member

replaced by #12256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants