Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/656/70x/20241203/v1 #12207

Merged
merged 2 commits into from
Dec 3, 2024
Merged

next/656/70x/20241203/v1 #12207

merged 2 commits into from
Dec 3, 2024

Conversation

victorjulien
Copy link
Member

@jasonish
output-json: drop eve records that are too long
3715fe3 
In the situation where the mem buffer cannot be expanded to the
requested size, drop the log message.

For each JSON log context, a warning will be emitted once with a partial
bit of the log record being dropped to identify what event types may be
leading to large log records.

This also fixes the call to MemBufferExpand which is supposed be
passed the amount to expand by, not the new size required.

Ticket: OISF#7300
(cherry picked from commit d39e427)
@jasonish
util-buffer: expand by multiples of 4k
093397f 
(cherry picked from commit 287d836)
jufajardini
jufajardini approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with approved PR

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23647

@victorjulien victorjulien merged commit 093397f into OISF:main-7.0.x Dec 3, 2024
84 of 88 checks passed
@victorjulien victorjulien mentioned this pull request Dec 3, 2024
Merged
@victorjulien victorjulien deleted the next/656/70x/20241203/v1 branch December 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini jufajardini approved these changes

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @jasonish @jufajardini