rust: fix latest clippy issues - v1 #12170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the clippy warning:
508 | #[derive(FromPrimitive, Debug)]
| ^------------
| |
| `FromPrimitive` is not local
| move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_IsakmpPayloadType`
509 | pub enum IsakmpPayloadType {
| ----------------- `IsakmpPayloadType` is not local
|
= note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed
= note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive`
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint
= note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info)
Fix provided by cargo clippy --fix.
'///' style rust comments/documentation come before the item being documented. Spotted by clippy.
But we should fix all these soon.
| @@ -32,7 +32,7 @@ crc = "~1.8.1" | |||
| lzma-rs = { version = "~0.2.0", features = ["stream"] } | |||
| memchr = "~2.4.1" | |||
| num = "~0.2.1" | |||
| num-derive = "~0.2.5" | |||
| num-derive = "~0.4.2" | |||
There was a problem hiding this comment.
does this require a cargo lock.in update as well?
|
Cargo.lock updated with #12171. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12170 +/- ##
==========================================
+ Coverage 49.81% 49.82% +0.01%
==========================================
Files 909 909
Lines 257904 257904
==========================================
+ Hits 128467 128511 +44
+ Misses 129437 129393 -44
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust: update num-dervice to 0.4.2
This prevents the clippy warning:
508 | #[derive(FromPrimitive, Debug)]
| ^------------
| |
|
FromPrimitiveis not local| move the
implblock outside of this constant_IMPL_NUM_FromPrimitive_FOR_IsakmpPayloadType509 | pub enum IsakmpPayloadType {
| -----------------
IsakmpPayloadTypeis not local|
= note: the derive macro
FromPrimitivedefines the non-localimpl, and may need to be changed= note: the derive macro
FromPrimitivemay come from an old version of thenum_derivecrate, try updating your dependency withcargo update -p num_derive= note: an
implis never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as theimpl= note: items in an anonymous const item (
const _: () = { ... }) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint= note: this warning originates in the derive macro
FromPrimitive(in Nightly builds, run with -Z macro-backtrace for more info)rust: remove unnecessary lifetimes
Fix provided by cargo clippy --fix.
rust/smb: fix rustdoc line
'///' style rust comments/documentation come before the item being
documented.
Spotted by clippy.
rust: allow static_mut_refs for now
But we should fix all these soon.