Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add rule to check for tcp_mss - v2 #1436

Closed
wants to merge 1 commit into from
Closed

tests: add rule to check for tcp_mss - v2 #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/rules/tcp-mss/test.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:50; sid:1;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:>123; sid:2;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:<536; sid:3;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:123-456; sid:4;)
Comment on lines +1 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it would make sense to include other rules with the other possible operands here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it would make sense to include other rules with the other possible operands here...

I wrote the rules based off the format instruction for tcp.mss provided on the userguide.

So I don't know exactly.

But if you say to add it, then no problem still.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I said I'm wondering. On the one hand, it makes sense to showcase what the userguide says. On the other, it can be good to stretch things a bit and see how Suri reacts, you see?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I said I'm wondering. On the one hand, it makes sense to showcase what the userguide says. On the other, it can be good to stretch things a bit and see how Suri reacts, you see?

Yes! I understand.

40 changes: 40 additions & 0 deletions tests/rules/tcp-mss/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
requires:
min-version: 7.0.0
pcap: false

args:
- --engine-analysis

checks:
- filter:
filename: rules.json
count: 1
match:
id: 1
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.value1: 50
- filter:
filename: rules.json
count: 1
match:
id: 2
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.mode: "greater than"
lists.packet.matches[0].tcp_mss.value1: 123
- filter:
filename: rules.json
count: 1
match:
id: 3
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.mode: "less than"
lists.packet.matches[0].tcp_mss.value1: 536
- filter:
filename: rules.json
count: 1
match:
id: 4
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.mode: "range"
lists.packet.matches[0].tcp_mss.value1: 123
lists.packet.matches[0].tcp_mss.value2: 456
Loading