Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]safari browser Unable to open,not support static {...} #4246

Open
857128237 opened this issue Jun 21, 2024 · 9 comments
Open

[Bug]safari browser Unable to open,not support static {...} #4246

857128237 opened this issue Jun 21, 2024 · 9 comments
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@857128237
Copy link

Describe the Bug

safari browser Unable to open https://viewer.ohif.org/

Steps to Reproduce

safari browsers Error unable to open https://viewer.ohif.org/

The current behavior

error info: SyntaxError: Unexpected token '{'

The expected behavior

Normal open https://viewer.ohif.org/
and Normal open Tag<v3.8.2>

OS

macOS 12.0.1

Node version

16.20.2

Browser

Safari 15.1

@857128237 857128237 added the Awaiting Reproduction Can we reproduce the reported bug? label Jun 21, 2024
@857128237 857128237 changed the title safari browser Unable to open [Bug]safari browser Unable to open Jun 21, 2024
@857128237 857128237 changed the title [Bug]safari browser Unable to open [Bug]safari browser Unable to open,not support static {...} Jun 21, 2024
@sedghi
Copy link
Member

sedghi commented Jun 21, 2024

it opens for me
CleanShot 2024-06-21 at 11 24 33@2x

update safari?

@857128237
Copy link
Author

@sedghi First of all, thank you for your reply。Because this issue has indeed occurred on both my Mac and phone, the issue should be whether the browser supports the writing style of "static {...}", and whether it is possible for Babel to further optimize it
6101719114405_ pic

@857128237
Copy link
Author

And I have tried many people's phones (including iPhone and Android), all of which have black screens, so I think it is a serious problem

@857128237
Copy link
Author

6131719122988_ pic

@857128237
Copy link
Author

I think it's because it didn't take effect: @babel/plugin-transform-class-static-block

@857128237
Copy link
Author

I have also seen other users mention this issue (#3941)

@857128237
Copy link
Author

If ES2015 is added to this place, it may solve this problem:https://github.com/cornerstonejs/cornerstone3D/blob/main/packages/core/tsconfig.esm.json,
Add to everything in the package
6161719148263_ pic

@857128237
Copy link
Author

@sedghi I asked https://github.com/cornerstonejs/cornerstone3D The tsconfig.esm.json in the core and tools have both been added with module: 'es2015' and target: 'es2015', and Safari will eventually be able to access them. I hope to synchronize or use other methods, which is very important to me. Thank you again
image

@sedghi
Copy link
Member

sedghi commented Jun 28, 2024

Hmmm, how old is this safari? I was thinking to even target es2022 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

2 participants