Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella Issue][Feature request] More Factory to Ohshown renaming in the django damin console #14

Open
3 of 18 tasks
tai271828 opened this issue Dec 15, 2021 · 10 comments
Open
3 of 18 tasks
Assignees
Milestone

Comments

@tai271828
Copy link

tai271828 commented Dec 15, 2021

Subtasks

Check list based on #14 (comment)

Cet review status -->Review Status

  • 尚未審查
  • 已審查, 臺灣黑熊(資料完整)
  • 已審查, 需進一步聯繫(資料不完整)

Cet report status -->Species check

  • 是臺灣黑熊
  • 不是臺灣黑熊
  • 其他物種(或許可以羅列其他常見物種,另開放一個自由填寫的欄位?)
  • 無法確定

Building status --> Report type

  • 目擊黑熊
  • 發現痕跡

Usage status --> Attributes

  • 目擊黑熊
  • 發現痕跡
  • 人熊衝突
  • 救傷事件

Details

  • Landcode, Sectname, Sectcode, Name --> These field could be delete . Track with Remove urban address #26
  • Factorys type --> Ohshown type

Other fields we will need in the future: Track with #34

  • Description of encounter place(發現地點描述)
  • Encounter date and time(發現日期時間)
  • Altitude (<-maybe after we add new gis layer with more geographic details)

More Notes of Screenshot That we Need to Rename

Selection_576

Selection_573

@EagleC0318
Copy link
Collaborator

EagleC0318 commented Dec 19, 2021

Hi @tai271828 , could you please check if this issue is still in current main-tbbca branch?
I don't see them as following screenshots. Thanks!
Btw, for the More Factory to Ohshown renaming issue, maybe I can rename the factory for the python classes and the admin API endpoint url.
image
image

@diaoga
Copy link
Collaborator

diaoga commented Dec 21, 2021

Renaming suggestion of fields in Ohshown Events

Cet review status -->Review Status

  • 尚未審查
  • 已審查, 臺灣黑熊(資料完整)
  • 已審查, 需進一步聯繫(資料不完整)

Cet report status -->Species check

  • 是臺灣黑熊
  • 不是臺灣黑熊
  • 其他物種(或許可以羅列其他常見物種,另開放一個自由填寫的欄位?)
  • 無法確定

Building status --> Report type

  • 目擊黑熊
  • 發現痕跡

Usage status --> Attributes

  • 目擊黑熊
  • 發現痕跡
  • 人熊衝突
  • 救傷事件

Details

  • Landcode, Sectname, Sectcode, Name --> These field could be delete

  • Factorys type --> Ohshown type
    I think maybe this field could be delete?
    Field on top of this page may be enough

Other fields we will need in the future:

  • Altitude
  • Description of encounter place(發現地點描述)
  • Encounter date and time

@tai271828
Copy link
Author

tai271828 commented Jan 23, 2022

Some of the rewording tasks are completed and some of them do not.

Next step:
Divide this issue into smaller tasks based on this suggestion #14 (comment)

@tai271828 tai271828 changed the title [Feature request] More Factory to Ohshown renaming in the django damin console [Umbrella Issue][Feature request] More Factory to Ohshown renaming in the django damin console Jan 23, 2022
@tai271828 tai271828 modified the milestones: alpha, beta Feb 23, 2022
@EagleC0318
Copy link
Collaborator

@tai271828 @diaoga Could you please explain how did you decide the "Renaming suggestion of fields in Ohshown Events"? Are there any existing relationship or usage in the admin/FE UI flow between the fields and the OhShown Event?

@tai271828
Copy link
Author

@tai271828 @diaoga Could you please explain how did you decide the "Renaming suggestion of fields in Ohshown Events"? Are there any existing relationship or usage in the admin/FE UI flow between the fields and the OhShown Event?

我不太懂這個問題~~ 這個 issue 單純是把既有的 admin console 中的名字換成比較適合 ohshown 專案的名字;是完全一對一的關係,沒有建立新的 field (不確定我有沒有回答到你 Orz )

@EagleC0318
Copy link
Collaborator

@tai271828 我想問的比較像是,為什麼是把A改成B,而不是把C改成B? 有點像是 @Neilxx 在3/9 meeting note裡的問題,我們之所以決定這樣改,是有參考過Disfacoty的flow,覺得這樣改比較適合嗎?還是單純就是隨便找個field來rename?

@tai271828
Copy link
Author

懂了!

quick answer: Yes,參考過才改的,不是隨便改的。每一個 field 都是 @diaoga 按照他認為合理[1]的方式重新命名的。

long answer: 我直接更新 3/9 meeting note 上對應的問題,補上我知道的資訊,感謝 heads-up!

@diaoga 再麻煩你看看我說得跟你想得有沒有一樣,如果有不一樣歡迎糾正我喔~~

[1] 合理:根據 @diaoga 的專業加上第一版的 flow chart 與既有的程式碼限制互相配合的結果

@tai271828 我想問的比較像是,為什麼是把A改成B,而不是把C改成B? 有點像是 @Neilxx 在3/9 meeting note裡的問題,我們之所以決定這樣改,是有參考過Disfacoty的flow,覺得這樣改比較適合嗎?還是單純就是隨便找個field來rename?

@diaoga
Copy link
Collaborator

diaoga commented Mar 16, 2022

@tai271828 說的一樣,我只是按照我心中對資料架構的了解,用一組一組的方式,把舊的field重新命名。
That is, the renaming of BE field is independent to FE UI

@diaoga
Copy link
Collaborator

diaoga commented Mar 16, 2022

According to 220313 PyCon APAC development sprint note

目前決定不去改動原本的disfactory table,將依據oh_shown的需求建立自己要的table

Is the Renaming of the django admin console will still be an issue? Or we could establish a whole new table?

@tai271828
Copy link
Author

According to 220313 PyCon APAC development sprint note

目前決定不去改動原本的disfactory table,將依據oh_shown的需求建立自己要的table

Is the Renaming of the django admin console will still be an issue? Or we could establish a whole new table?

@diaoga from what I understand according the the 0313 note, we will establish a whole new table (and kept the original one alive until we refactored it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants