Access violation from dInternalStepIsland_x2()

[klaufir216]

Crash happened when grabbing the fridge at Agroprom top floor with Shift+F. Unfortunately could not reproduce, no matter how many times I tried.

Version

Engine version: 3.490 (x64) from repo: [OGSR/OGSR-Engine]

Stack trace

[15.01.26 00:30:37.047] [44352] ***************************[ScriptCrashHandler]**********************************
[15.01.26 00:30:37.048] [44352] stack traceback:
[15.01.26 00:30:37.048] [44352] *********************************************************************************
[15.01.26 00:30:37.048] [44352] ********************************************************************************
[15.01.26 00:30:37.048] [44352] !![LogStackTrace] Thread: [X-RAY Primary thread], ExceptionCode: [c0000005]
[15.01.26 00:30:38.172] [44352] !!Unhandled exception stack trace:
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF76801C9EA], Fun: [dInternalStepIsland_x2()] + [7034 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\3rd_party\Src\ode\ode\src\step.cpp-->770] + [26 byte(s)]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF76800F497], Fun: [dxProcessIslands()] + [263 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\3rd_party\Src\ode\ode\src\util.cpp-->328]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF767786ADB], Fun: [CPHWorld::Step()] + [507 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xrGame\PHWorld.cpp-->254] + [13 byte(s)]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF76783A5AF], Fun: [CPHMovementControl::ActivateBoxDynamic()] + [2319 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xrGame\PHMovementDynamicActivate.cpp-->390]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF767707261], Fun: [CActor::g_cl_ValidateMState()] + [1089 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xrGame\Actor_Movement.cpp-->145] + [26 byte(s)]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7676C0777], Fun: [CActor::shedule_Update()] + [951 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xrGame\Actor.cpp-->1015]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7673E0772], Fun: [CSheduler::Update()] + [194 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\xrSheduler.cpp-->361]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF767939154], Fun: [CGamePersistent::OnFrame()] + [932 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xrGame\GamePersistent.cpp-->607] + [12 byte(s)]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF767425F99], Fun: [CRegistrator<pureFrame>::Process()] + [73 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\pure.h-->144]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF767425507], Fun: [CRenderDevice::FrameMove()] + [519 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\device.cpp-->501]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF767424860], Fun: [CRenderDevice::on_idle()] + [528 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\device.cpp-->261]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7674251E7], Fun: [CRenderDevice::Run()] + [807 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\device.cpp-->455] + [68 byte(s)]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7673D9D2D], Fun: [Startup()] + [1405 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\x_ray.cpp-->245]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7673DA7BB], Fun: [WinMain_impl()] + [763 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\x_ray.cpp-->428]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7673DA8A9], Fun: [WinMain()] + [9 byte(s)], File-->Line: [D:\a\OGSR-Engine\OGSR-Engine\ogsr_engine\xr_3da\x_ray.cpp-->446]
! Module: [V:\Games\OGSR\bin_x64\xrEngine.exe], AddrPC.Offset: [00007FF7681532DA], Fun: [__scrt_common_main_seh()] + [262 byte(s)], File-->Line: [D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl-->288] + [33 byte(s)]
! Module: [C:\Windows\System32\KERNEL32.DLL], AddrPC.Offset: [00007FFD970A7374], Fun: [BaseThreadInitThunk()] + [20 byte(s)]
! Module: [C:\Windows\SYSTEM32\ntdll.dll], AddrPC.Offset: [00007FFD973FCC91], Fun: [RtlUserThreadStart()] + [33 byte(s)]
! 
[15.01.26 00:30:38.172] [44352] ********************************************************************************

[klaufir216]

Very similar issue reported here:

https://ap-pro.ru/forums/topic/2371-op-ogsr/?do=findComment&comment=378079

[klaufir216]

My suspicion is that alloca calls make the process run out of stack memory.

Running

dumpbin /headers xrEngine.exe

Give the stack size in hex:

OPTIONAL HEADER VALUES
...
          100000 size of stack reserve
...

So 0x100000 hex = 1048576 dec bytes, 1 MB of stack space.

A possible mitigation would be raising the stack size for the build from 1MB -> 4MB (4194304)

[xrSimpAI]

We can increase the stack size; this might be useful in some cases. But in this case, it's unlikely to be the cause of the crash.

[klaufir216]

Yeah, was just a guess. Some extra info:

ODE commits affecting step.cpp:
https://github.com/hsu/open-dynamics-engine/commits/master/ode/src/step.cpp

Looking at the commits of step.cpp in https://github.com/hsu/open-dynamics-engine, the version in OGSR-Engine is
c9b2c3b (May 18, 2004)