Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up default UX #82

Open
LukeTowers opened this issue Jul 14, 2019 · 1 comment
Open

Clean up default UX #82

LukeTowers opened this issue Jul 14, 2019 · 1 comment

Comments

@LukeTowers
Copy link

There are a lot of third party custom search providers included by default. In my opinion these should live within the plugins they are for (and if that's not possible, then at the very least the existence of the plugin they're for should be checked on the settings page before displaying that provider's options).

On another note, it would be ideal if the Settings model could pull defaults from a plugin configuration file (see how October implements it: https://github.com/octobercms/october/blob/master/modules/backend/models/BrandSetting.php#L77 - although you'd want to override the get method of the settings model in this case to load from config when an item is requested to retain full support for custom provider's settings). I try to avoid any database configuration in my projects instead utilizing configuration files and the environment file as this enables the code to configure itself without requiring any manual intervention on deployment to new servers.

@damsfx
Copy link
Contributor

damsfx commented Nov 22, 2022

There are a lot of third party custom search providers included by default. In my opinion these should live within the plugins they are for (and if that's not possible, then at the very least the existence of the plugin they're for should be checked on the settings page before displaying that provider's options).

This par of the issue is resolved with #124 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants