geoalchemy vs geoalchemy2 dependency

[emiliom]

@sreeder and @horsburgh: I'm creating this issue to help us keep track of the status.

Stephanie, were you able to make progress on this last week?

[sreeder]

This issue has been completed in the geometry branch and has been merged into the setup branch

[emiliom]

@sreeder, one question: when we talked on the phone I think you said that using geoalchemy would involve making some changes to it. Was that the case, or am I mixing things up? If it is true, it means we'll have to maintain our own fork of geoalchemy in the ODM2 github organization. Not a problem per se, just wanted to make that clear.

[sreeder]

@emiliom Yes, there is one classname that has to be changed. I have made a note of it in the requirements.txt file. But I have been planning on keeping our own copy in the repository, thanks for the reminder.

[emiliom]

This is just for reference:

• Stephanie's change to geoalchemy (copied from requirements.txt): Change line #242 in geoalchemy/base.py from: class SpatialComparator(ColumnProperty.ColumnComparator): to class SpatialComparator(ColumnProperty.Comparator):
• A 2014-Aug report on the same import geoalchemy error, from the geoalchemy Google Groups list. No one replied (that's not surprising).

[emiliom]

I've forked geoalchemy into the ODM2 org: https://github.com/ODM2/geoalchemy. Then I created a branch (odm2) and made Stephanie's single-line edit there. Then I tested by first installing this fork/branch via pip install git+https://github.com/ODM2/geoalchemy.git@odm2, then installing odm2api (setup_em branch) via pip install git+https://github.com/ODM2/ODM2PythonAPI.git@setup_em.

So far so good! import odm2api and import geoalchemy didn't complain.

I don't know how to specify a github repo, rather than the pypi default, as the source of a dependency requirement; so I didn't change the requirements/setup files in odm2api. Hopefully @sreeder can take care of that, specially once we promote my geoalchemy odm2 branch to master (I was just being extra careful).

[emiliom]

Things to follow up on, probably as separate issues:

• Is odm2api.ODM2.apiCustomType no longer used anywhere? I assume so, b/c it has a geoalchemy2 import statement, so that would throw an error. If this is the case, it should be removed (or better yet, an experimental geoalchemy2 branch should be created and used as a future reference/archive). But I wonder if the now missing functionality from that module is related to the possible problems/unexpected behavior I've run into.
• In odm2api.ODM2.models, the use of from geoalchemy import * should be changed so geoalchemy is imported with a namespace. Importing everything makes debugging more difficult, and may lead to unexpected conflicts.
• SamplingFeatures.FeatureGeometry is currently hardwired (in odm2api.ODM2.models) to support only Point feature types. This will need to be addressed, but that can happen in follow-up development, say in a geometry branch.

Also see my related, latest comment in issue 11.

[sreeder]

@emiliom
you are correct, the apiCustomType is no longer being used.
I will work on changing over the import statement and see if there is a simple way to expand the support of feature types beyond Point. I'm not sure the best way to address the shaply issue at the moment but I may be able to write a custom repr function that will print it out as WKT.

[valentinedwv]

I changed the dependencies in setup.py and requirements.txt.
On Windows you may/will need to add git to your path. for me it was:
C:\Program Files (x86)\Git\cmd

[emiliom]

Thanks, @valentinedwv ! Have you tested this? I tried installing, letting pip install git+https://github.com/ODM2/ODM2PythonAPI.git handle the geoalchemy dependency. Instead of installing odm2/geoalchemy.git@odm2 (labelled as version 0.7.3dev), it installed geoalchemy from pypi (0.7.2).

I don't know enough about pip packaging to figure out what's wrong.

[emiliom]

Just more confirmation that the setup dependency requirement for geoalchemy is not configured correctly. My odm2api tests ran just fine when I pre-installed geoalchemy via pip install, like this:

pip install git+https://github.com/ODM2/geoalchemy.git@odm2
pip install git+https://github.com/ODM2/ODM2PythonAPI.git

[valentinedwv]

Didn't hard core check it, but when I ran it in pycharm, it complained about not pulling from git...
Checking now pycharm shows 0.7.3.dev0
As for setup... getting whacked with shapley.

Added >= to geoalchemy to see if that forces it.