Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP improvements #13

Merged
merged 17 commits into from
Oct 2, 2023
Merged

LSP improvements #13

merged 17 commits into from
Oct 2, 2023

Conversation

nberth
Copy link
Collaborator

@nberth nberth commented Sep 15, 2023 •
edited
Loading

This improves the LSP via:

  • A refactoring of its internal code, and add handling for every kind of Jsonrpc messages that was previously missing;
  • The emission of semantic tokens ("semtoks") for comments and (some) pre-processor directives;
  • A new ability to reply with ranged semtoks (i.e. on a restricted portion of a file);
  • New support for folding-range requests.

Slight alterations of the AST representation for PERFORM and SEARCH (ALL) statements also come along.

At last, included changes remove the completion capability, that is only partially implemented.

@nberth nberth force-pushed the lsp-improvements branch 4 times, most recently from 22569c4 to e471abb Compare September 21, 2023 14:03
@nberth nberth mentioned this pull request Sep 21, 2023
Merged
@nberth nberth mentioned this pull request Sep 22, 2023
Merged
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nberth nberth force-pushed the lsp-improvements branch 4 times, most recently from beed08c to d502765 Compare September 26, 2023 13:37
@nberth nberth marked this pull request as ready for review September 26, 2023 15:10
@nberth nberth marked this pull request as draft September 26, 2023 15:41
@nberth nberth force-pushed the lsp-improvements branch 2 times, most recently from d7418ed to 9a73da1 Compare September 27, 2023 09:52
@nberth nberth marked this pull request as ready for review September 27, 2023 12:27
@nberth nberth added the ok to review As its name says label Sep 27, 2023
@nberth
Extract preprocessor logs into a dedicated module
113beb1 
This also comes with various refactorings here and there.
@nberth
Make Cobol_preproc record comments
839d858
@nberth
Refactor Cobol_lsp.Lsp_semtoks (renamed from Lsp_semantic)
ee78b32
@nberth
Rework LSP internals, emit semantic tokens for comments
f621cd4 
A more efficient generation of semantic tokens may require parse-tree
nodes to be visited in the same order as in the source code.  This
commit also starts implementing the necessary changes to enforce that
behavior.
@nberth
Use distinct AST representations for SEARCH and SEARCH ALL
2564883
@nberth
Emit semantic tokens for COPY and REPLACE preprocessor statements
616a10a
@nberth
Emit macro semantic tokens in proper order; more doc in `Cobol_common…
7d36692 
….Srcloc`
@nberth
Add support for ranged semantic tokens requests
c3b2019
@nberth
Extract LSP capabilities out of Lsp_request
2000b52
@nberth nberth merged commit fd3b888 into OCamlPro:master Oct 2, 2023
3 checks passed
@nberth nberth deleted the lsp-improvements branch October 2, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefessan lefessan Awaiting requested review from lefessan

Assignees
No one assigned
Labels
ok to review As its name says
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nberth @CLAassistant @lefessan @WeituoDAI