Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit float conversions #95

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Add explicit float conversions #95

merged 3 commits into from
Sep 20, 2024

Conversation

vouillon
Copy link
Contributor

This will eventually be mandatory for compatibility with Wasm_of_ocaml.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@maxtori
Copy link
Collaborator

maxtori commented Sep 20, 2024

Thanks!
What branch of js_of_ocaml/wasm_of_ocaml are you using to check the deprecation? I probably need to change these points in a lot of projects.

@vouillon
Copy link
Contributor Author

You can either install js_of_ocaml from the wasm_of_ocaml repository or from ocsigen/js_of_ocaml#1650. The second option is simpler since you don't need to update dune.
You will get type errors if you don't use the Js_of_ocaml library properly, but not from your own bindings if they are using type float instead of Js.number_t. But you can grep for the type float.

@maxtori maxtori merged commit 4fa7bb0 into OCamlPro:master Sep 20, 2024
1 of 2 checks passed
@vouillon vouillon deleted the wasm branch September 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants