Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dune warning on merlin #239

Open
Ninjapouet opened this issue Aug 28, 2024 · 1 comment
Open

Remove the dune warning on merlin #239

Ninjapouet opened this issue Aug 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Ninjapouet
Copy link

... when using a recent dune.

$ make
./scripts/before.sh build
opam exec -- dune build @install
File "dune-project", lines 4-46, characters 0-742:
 4 | (cram enable)
 5 | (name columns)
 6 | (allow_approximate_merlin)
....
44 |    ocamlformat
45 |   )
46 |  )
Warning: This field was deprecated in version 2.8 of the dune language. It is
useless since the Merlin configurations are not ambiguous anymore.
@Ninjapouet Ninjapouet added the enhancement New feature or request label Aug 28, 2024
@Halbaroth
Copy link

How did you get this message? I tried to reproduce it but I got it only if I change the minimum version of dune language in dune-project for 2.8. My version of dune is 3.16.0.

It could be a bug in dune because there is a cram test to check that dune won't emit a warning if the dune language version is smaller than 2.7:
https://github.com/ocaml/dune/blob/main/test/blackbox-tests/test-cases/merlin/allow_approximate_merlin_warn.t/run.t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants