[IMP] web_form_banner: imp tests

Author: AungKoKoLin1997

web_form_banner/demo/web_form_banner_rule_demo.xml

@@ -32,7 +32,7 @@ else:
         <field name="model_id" ref="base.model_res_partner" />
         <field
             name="trigger_field_ids"
-            eval="[(6, 0, [ref('base.field_res_partner__email')])]"
+            eval="[Command.set([ref('base.field_res_partner__email')])]"
         />
         <field name="severity">warning</field>
         <field name="target_xpath">//sheet</field>
@@ -49,7 +49,7 @@ else:
         <field name="model_id" ref="base.model_res_partner" />
         <field
             name="trigger_field_ids"
-            eval="[(6, 0, [ref('base.field_res_partner__category_id')])]"
+            eval="[Command.set([ref('base.field_res_partner__category_id')])]"
         />
         <field name="severity">danger</field>
         <field name="target_xpath">//field[@name='category_id']</field>

web_form_banner/tests/test_web_form_banner.py

@@ -13,17 +13,65 @@ def setUpClass(cls):
         super().setUpClass()
         cls.Partner = cls.env["res.partner"]
         cls.Rule = cls.env["web.form.banner.rule"]
-        cls.rule_name = cls.env.ref("web_form_banner.demo_rule_partner_name_length")
-        cls.rule_email = cls.env.ref("web_form_banner.demo_rule_partner_email_missing")
-        cls.rule_tag = cls.env.ref("web_form_banner.demo_rule_partner_tag_missing")
-        # Disable the email and tag rules to avoid interference in most tests
-        cls.rule_email.active = False
-        cls.rule_tag.active = False
+        existing_rules = cls.Rule.search([])
+        cls._disabled_rule_ids = existing_rules.ids
+        if existing_rules:
+            existing_rules.write({"active": False})
+        partner_model_id = cls.env["ir.model"]._get("res.partner").id
+        cls.rule_name = cls.Rule.create(
+            {
+                "name": "Partner name length notice",
+                "model_id": partner_model_id,
+                "message_value_code": """
+name = (record.name or "").strip()
+n = len(name)
+if n > 20:
+    result = {
+        "visible": True,
+        "severity": "danger",
+        "html": "Name too long!",
+    }
+elif n > 10:
+    result = {
+        "visible": True,
+        "severity": "warning",
+        "html": "Name a bit long.",
+    }
+else:
+    result = {"visible": False}
+            """,
+            }
+        )
+        cls.rule_email = cls.Rule.create(
+            {
+                "name": "Partner email missing notice (dynamic)",
+                "model_id": partner_model_id,
+                "message": "Email missing!",
+                "message_value_code": "{'visible': not bool(draft.email)}",
+                "active": False,  # disable to avoid interference in most tests
+            }
+        )
+        cls.rule_tag = cls.Rule.create(
+            {
+                "name": "Partner tag missing notice (dynamic)",
+                "model_id": partner_model_id,
+                "message": "Missing tag!",
+                "message_value_code": "{'visible': not bool(draft.category_id)}",
+                "active": False,  # disable to avoid interference in most tests
+            }
+        )
         cls.partner_form_view = cls.env.ref("base.view_partner_form")
         cls.p_len3 = cls.Partner.create({"name": "Bob"})  # 3
         cls.p_len12 = cls.Partner.create({"name": "Yoshi Tashiro"})  # 12
         cls.p_len22 = cls.Partner.create({"name": "Professor Charles Xavier"})  # 22
 
+    @classmethod
+    def tearDownClass(cls):
+        # restore previously active rules
+        if getattr(cls, "_disabled_rule_ids", None):
+            cls.Rule.browse(cls._disabled_rule_ids).exists().write({"active": True})
+        super().tearDownClass()
+
     def _get_arch_tree(self, model, view):
         res = model.get_view(view_id=view.id, view_type="form")
         return etree.fromstring(res["arch"])
@@ -90,8 +138,8 @@ def test_not_injected_on_unrelated_model(self):
 
     def test_contains_expected_messages_and_severities(self):
         code = (self.rule_name.message_value_code or "").strip()
-        self.assertIn("This partner's name is very long!", code)
-        self.assertIn("This partner's name is a bit long.", code)
+        self.assertIn("Name too long!", code)
+        self.assertIn("Name a bit long.", code)
         self.assertRegex(code, r"['\"]danger['\"]", "Missing 'danger' literal")
         self.assertRegex(code, r"['\"]warning['\"]", "Missing 'warning' literal")
 
@@ -114,7 +162,7 @@ def test_banner_visibility_and_content(self):
         )
         self.assertTrue(out.get("visible"))
         self.assertEqual(out.get("severity"), "danger")
-        self.assertIn("very long", out.get("html", ""))
+        self.assertIn("too long", out.get("html", ""))
 
     def test_inactive_rule_returns_hidden(self):
         # Flip active off just for this check
@@ -133,7 +181,7 @@ def test_compute_message_dynamic_simple_field(self):
             self.rule_email.id, "res.partner", self.p_len3.id, form_vals={"email": ""}
         )
         self.assertTrue(out.get("visible"))
-        self.assertIn("This partner is missing email!", out.get("html"))
+        self.assertIn("Email missing!", out.get("html"))
         out = self.Rule.compute_message(
             self.rule_email.id,
             "res.partner",
@@ -152,7 +200,7 @@ def test_compute_message_dynamic_m2m(self):
             form_vals={"category_id": []},
         )
         self.assertTrue(out.get("visible"))
-        self.assertIn("Tag is missing!", out.get("html"))
+        self.assertIn("Missing tag!", out.get("html"))
         out = self.Rule.compute_message(
             self.rule_tag.id,
             "res.partner",