[MIG] web_form_banner: Migration to 17.0

Author: AungKoKoLin1997

web_form_banner/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
     "name": "Web Form Banner",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Web",
     "author": "Quartile, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/web",

web_form_banner/models/web_form_banner_rule.py

@@ -2,7 +2,6 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 import logging
-from functools import lru_cache
 from string import Template
 
 from dateutil import parser as dateparse
@@ -39,7 +38,7 @@ def _extract_m2o_id(v):
     """Normalize many2one values to an integer id or False."""
     if isinstance(v, int):
         return v
-    if isinstance(v, (list, tuple)) and v and isinstance(v[0], int):
+    if isinstance(v, list | tuple) and v and isinstance(v[0], int):
         return v[0]
     if isinstance(v, dict):
         m2o_id = v.get("res_id") or v.get("id")
@@ -49,12 +48,12 @@ def _extract_m2o_id(v):
 
 
 def _m2m_items(value):
-    if isinstance(value, (list, tuple)):
+    if isinstance(value, list | tuple):
         return value
     if isinstance(value, dict):
-        if isinstance(value.get("resIds"), (list, tuple)):
+        if isinstance(value.get("resIds"), list | tuple):
             return value["resIds"]
-        if isinstance(value.get("data"), (list, tuple)):
+        if isinstance(value.get("data"), list | tuple):
             return value["data"]
     return None
 
@@ -172,9 +171,8 @@ def _build_form_url(self, rec):
             _logger.exception("Failed building form URL for %s", rec)
             return ""
 
-    @lru_cache(maxsize=1)
+    @api.model
     def _base_eval_ctx_static(self):
-        # Only static, import-heavy items
         return {
             "time": tools.safe_eval.time,
             "datetime": tools.safe_eval.datetime,

web_form_banner/security/ir.model.access.csv

@@ -1,3 +1,5 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_web_form_banner_rule_all,web_form_banner_rule_all,model_web_form_banner_rule,,1,0,0,0
+access_web_form_banner_rule_public,web_form_banner_rule_public,model_web_form_banner_rule,base.group_public,1,0,0,0
+access_web_form_banner_rule_portal,web_form_banner_rule_portal,model_web_form_banner_rule,base.group_portal,1,0,0,0
+access_web_form_banner_rule_user,web_form_banner_rule_user,model_web_form_banner_rule,base.group_user,1,0,0,0
 access_web_form_banner_rule_group_system,web_form_banner_rule_group_system,model_web_form_banner_rule,base.group_system,1,1,1,1

web_form_banner/static/src/js/web_form_banner.esm.js

@@ -3,8 +3,9 @@
 // License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 import {patch} from "@web/core/utils/patch";
-import {onMounted, onPatched, onWillUnmount} from "@odoo/owl";
+import {onMounted, onWillUnmount} from "@odoo/owl";
 import {FormController} from "@web/views/form/form_controller";
+import {Record} from "@web/model/relational_model/record";
 
 const recRoot = (c) => (c && c.model && c.model.root) || null;
 const childSpan = (el) => {
@@ -29,11 +30,12 @@ function normalizeValue(v) {
     if (v === null || v === undefined) return v; // Null/undefined
     const t = typeof v;
     if (t === "string" || t === "number" || t === "boolean") return v;
-    if (Array.isArray(v) && v.length === 2 && typeof v[1] === "string") return v[0]; // M2o [id, name]
+    if (Array.isArray(v))
+        return v.length === 2 && typeof v[1] === "string" ? v[0] : [...v]; // M2o id or cloned m2m ids
     if (t === "object") {
         if (typeof v.res_id === "number") return v.res_id; // M2o snapshot
         if (typeof v.id === "number") return v.id; // M2o env
-        if (Array.isArray(v.resIds)) return v.resIds; // M2m
+        if (Array.isArray(v._currentIds)) return [...v._currentIds]; // M2m
     }
     return undefined; // Ignore others (e.g., command lists)
 }
@@ -119,26 +121,35 @@ function tick(ctrl) {
     }, 180);
 }
 
-patch(FormController.prototype, "web_form_banner.lean", {
+patch(FormController.prototype, {
     setup() {
-        this._super(...arguments);
+        super.setup();
+        this.model.__controller = this;
         onMounted(() => scheduleRefresh(this));
-        onPatched(() => tick(this));
         onWillUnmount(() => clearTimeout(this.__wfbTimer));
     },
-    async edit() {
-        const r = await this._super(...arguments);
-        scheduleRefresh(this);
-        return r;
-    },
     async discard() {
-        const r = await this._super(...arguments);
+        const r = await super.discard(...arguments);
         scheduleRefresh(this);
         return r;
     },
-    async saveButtonClicked(p = {}) {
-        const ok = await this._super(p);
+    async save(p = {}) {
+        const ok = await super.save(p);
         if (ok) scheduleRefresh(this);
         return ok;
     },
 });
+
+const _superApplyChanges = Record.prototype._applyChanges;
+patch(Record.prototype, {
+    _applyChanges(changes, serverChanges = {}) {
+        const res = _superApplyChanges.call(this, changes, serverChanges);
+        try {
+            if (this.model && this.model.root === this) {
+                const ctrl = this.model.__controller;
+                if (ctrl) tick(ctrl);
+            }
+        } catch {}
+        return res;
+    },
+});

web_form_banner/views/web_form_banner_rule_views.xml

@@ -38,7 +38,7 @@
                         name="web_ribbon"
                         title="Archived"
                         bg_color="bg-danger"
-                        attrs="{'invisible': [('active', '=', True)]}"
+                        invisible="active == True"
                     />
                     <div class="oe_title">
                         <label for="name" class="oe_edit_only" />
@@ -77,10 +77,7 @@
                             name="message"
                             placeholder="This is a ${severity} message."
                         />
-                        <field
-                            name="message_is_html"
-                            attrs="{'invisible':[('message','=',False)]}"
-                        />
+                        <field name="message_is_html" invisible="message == False" />
                     </group>
                     <notebook>
                         <page