[UPD] web_m2x_options_manager: overhaul

* align M2ODialog option configuration to other options
* allow configuring models' inverse fields too
* add proper menu and views
* refactoring
* improve tests

Author: SilvioC2C

web_m2x_options_manager/README.rst

@@ -41,11 +41,16 @@ Usage
 
 Go to Settings > Technical > Models.
 
-Choose the model you wish to edit, and open its form view. Go to the
-"Create/Edit Options" tab, and add the fields you want to manage.
+Choose the model you wish to edit, and open its form view. Go to the "Create/Edit Options" tab,
+and add the fields you want to manage in 2 different sections:
 
-Button "Fill" will add every missing field to the options.
-Button "Empty" will remove every option.
+* the first list view allows you to handle fields for the selected model
+* the second list view allows you handle fields where the selected model is the comodel
+
+For both sections:
+
+* button "Fill" will add every missing field to the options
+* button "Empty" will remove every option
 
 Bug Tracker
 ===========

web_m2x_options_manager/__init__.py

@@ -1,4 +1,2 @@
-# Copyright 2021 Camptocamp SA
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
 from . import models
+from .hooks import pre_init_hook

web_m2x_options_manager/__manifest__.py

@@ -6,18 +6,25 @@
     "summary": 'Adds an interface to manage the "Create" and'
     ' "Create and Edit" options for specific models and'
     " fields.",
-    "version": "14.0.1.3.0",
+    "version": "14.0.2.0.0",
     "author": "Camptocamp, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "category": "Web",
     "data": [
         "security/ir.model.access.csv",
         "views/ir_model.xml",
+        "views/m2x_create_edit_option.xml",
     ],
     "demo": [
         "demo/res_partner_demo_view.xml",
     ],
-    "depends": ["base", "web_m2x_options"],
+    "depends": [
+        # OCA/server-tools
+        "base_view_inheritance_extension",
+        # OCA/web
+        "web_m2x_options",
+    ],
     "website": "https://github.com/OCA/web",
     "installable": True,
+    "pre_init_hook": "pre_init_hook",
 }

web_m2x_options_manager/demo/res_partner_demo_view.xml

@@ -9,17 +9,18 @@
             <form>
                 <sheet>
                     <group>
-                        <!-- Many2one -->
+                        <!-- Many2one w/o options -->
                         <field name="title" />
-                        <!-- Many2many -->
-                        <field name="category_id" options="{'create': False}" />
-                        <!-- One2many -->
-                        <field name="user_ids">
-                            <tree>
-                                <!-- Many2one within tree -->
-                                <field name="company_id" options="{'create': False}" />
-                            </tree>
-                        </field>
+                        <!-- Many2one w/ options -->
+                        <field
+                            name="parent_id"
+                            options="{'create': False, 'create_edit': False, 'm2o_dialog': False}"
+                        />
+                        <!-- Many2many w/ options -->
+                        <field
+                            name="category_id"
+                            options="{'create': False, 'create_edit': False, 'm2o_dialog': False}"
+                        />
                     </group>
                 </sheet>
             </form>

web_m2x_options_manager/hooks.py

@@ -0,0 +1,11 @@
+# Copyright 2025 Camptocamp SA
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from .tools import prepare_column_can_have_options, prepare_column_comodel_id
+
+
+def pre_init_hook(cr):
+    # Pre-create and pre-fill these columns for perf reasons (might take a while to
+    # let Odoo do it via the ORM for huge DBs)
+    prepare_column_can_have_options(cr)
+    prepare_column_comodel_id(cr)

web_m2x_options_manager/i18n/it.po

@@ -34,7 +34,7 @@ msgid "Create & Edit Option"
 msgstr "Opzione crea & modifica"
 
 #. module: web_m2x_options_manager
-#: model:ir.model.fields,field_description:web_m2x_options_manager.field_m2x_create_edit_option__option_create_edit_wizard
+#: model:ir.model.fields,field_description:web_m2x_options_manager.field_m2x_create_edit_option__option_m2o_dialog
 msgid "Create & Edit Wizard"
 msgstr "Procedura guidata crea & modifica"
 
@@ -59,7 +59,7 @@ msgid "Created on"
 msgstr "Creato il"
 
 #. module: web_m2x_options_manager
-#: model:ir.model.fields,help:web_m2x_options_manager.field_m2x_create_edit_option__option_create_edit_wizard
+#: model:ir.model.fields,help:web_m2x_options_manager.field_m2x_create_edit_option__option_m2o_dialog
 msgid ""
 "Defines behaviour for 'Create & Edit' Wizard\n"
 "Set to False to prevent 'Create & Edit' Wizard to pop up"
@@ -180,7 +180,7 @@ msgid "Last Updated on"
 msgstr "Ultimo aggiornamento il"
 
 #. module: web_m2x_options_manager
-#: model:ir.model.fields,field_description:web_m2x_options_manager.field_ir_model__m2x_create_edit_option_ids
+#: model:ir.model.fields,field_description:web_m2x_options_manager.field_ir_model__m2x_option_ids
 msgid "M2X Create Edit Option"
 msgstr "Crea opzione modifica M2X"
 

web_m2x_options_manager/i18n/web_m2x_options_manager.pot

@@ -31,7 +31,7 @@ msgid "Create & Edit Option"
 msgstr ""
 
 #. module: web_m2x_options_manager
-#: model:ir.model.fields,field_description:web_m2x_options_manager.field_m2x_create_edit_option__option_create_edit_wizard
+#: model:ir.model.fields,field_description:web_m2x_options_manager.field_m2x_create_edit_option__option_m2o_dialog
 msgid "Create & Edit Wizard"
 msgstr ""
 
@@ -56,7 +56,7 @@ msgid "Created on"
 msgstr ""
 
 #. module: web_m2x_options_manager
-#: model:ir.model.fields,help:web_m2x_options_manager.field_m2x_create_edit_option__option_create_edit_wizard
+#: model:ir.model.fields,help:web_m2x_options_manager.field_m2x_create_edit_option__option_m2o_dialog
 msgid ""
 "Defines behaviour for 'Create & Edit' Wizard\n"
 "Set to False to prevent 'Create & Edit' Wizard to pop up"
@@ -158,7 +158,7 @@ msgid "Last Updated on"
 msgstr ""
 
 #. module: web_m2x_options_manager
-#: model:ir.model.fields,field_description:web_m2x_options_manager.field_ir_model__m2x_create_edit_option_ids
+#: model:ir.model.fields,field_description:web_m2x_options_manager.field_ir_model__m2x_option_ids
 msgid "M2X Create Edit Option"
 msgstr ""
 

web_m2x_options_manager/migrations/14.0.2.0.0/pre-mig.py

@@ -0,0 +1,41 @@
+# Copyright 2025 Camptocamp SA
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo.tools.sql import column_exists, create_column, drop_constraint
+
+# pylint: disable=odoo-addons-relative-import
+from odoo.addons.web_m2x_options_manager.tools import (
+    prepare_column_can_have_options,
+    prepare_column_comodel_id,
+)
+
+
+def migrate(cr, version):
+    if not version:
+        return
+
+    # Migrate values from ``option_create_edit_wizard`` to ``option_m2o_dialog``
+    if not column_exists(cr, "m2x_create_edit_option", "option_m2o_dialog"):
+        create_column(cr, "m2x_create_edit_option", "option_m2o_dialog", "varchar")
+    cr.execute(
+        """
+        UPDATE m2x_create_edit_option
+        SET option_m2o_dialog =
+            CASE
+                WHEN not option_create_edit_wizard THEN 'set_false'
+                ELSE 'null'
+            END
+        """
+    )
+
+    # Pre-create and pre-fill these columns for perf reasons (might take a while to
+    # let Odoo do it via the ORM for huge DBs)
+    prepare_column_can_have_options(cr)
+    prepare_column_comodel_id(cr)
+
+    # Replaced by SQL constraint ``m2x_create_edit_option_field_uniqueness``
+    drop_constraint(
+        cr,
+        tablename="m2x_create_edit_option",
+        constraintname="m2x_create_edit_option_model_field_uniqueness",
+    )

web_m2x_options_manager/models/__init__.py

@@ -1,6 +1,4 @@
-# Copyright 2021 Camptocamp SA
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
 from . import ir_model
+from . import ir_model_fields
 from . import ir_ui_view
 from . import m2x_create_edit_option

web_m2x_options_manager/models/ir_model.py

@@ -1,52 +1,68 @@
 # Copyright 2021 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import fields, models
 
 
 class IrModel(models.Model):
     _inherit = "ir.model"
 
-    m2x_create_edit_option_ids = fields.One2many(
+    m2x_option_ids = fields.One2many(
         "m2x.create.edit.option",
         "model_id",
     )
+    m2x_comodels_option_ids = fields.One2many(
+        "m2x.create.edit.option",
+        "comodel_id",
+    )
+    comodel_field_ids = fields.One2many("ir.model.fields", "comodel_id")
+
+    def button_empty_m2x_options(self):
+        for ir_model in self:
+            ir_model._empty_m2x_options(own=True)
 
-    def button_empty(self):
+    def button_fill_m2x_options(self):
         for ir_model in self:
-            ir_model._empty_m2x_create_edit_option()
+            ir_model._fill_m2x_options(own=True)
 
-    def button_fill(self):
+    def button_empty_m2x_comodels_options(self):
         for ir_model in self:
-            ir_model._fill_m2x_create_edit_option()
+            ir_model._empty_m2x_options(comodels=True)
 
-    def _empty_m2x_create_edit_option(self):
-        """Removes every option for model ``self``"""
+    def button_fill_m2x_comodels_options(self):
+        for ir_model in self:
+            ir_model._fill_m2x_options(comodels=True)
+
+    def _empty_m2x_options(self, own=False, comodels=False):
+        """Removes every option for model ``self``'s fields
+
+        :param bool own: if True, deletes options for model's fields
+        :param bool comodels: if True, deletes options for fields where ``self`` is comodel
+        """
         self.ensure_one()
-        self.m2x_create_edit_option_ids.unlink()
+        to_delete = self.env["m2x.create.edit.option"]
+        if own:
+            to_delete += self.m2x_option_ids
+        if comodels:
+            to_delete += self.m2x_comodels_option_ids
+        if to_delete:
+            to_delete.unlink()
+
+    def _fill_m2x_options(self, own=False, comodels=False):
+        """Adds every missing field option for model ``self`` (with default values)
 
-    def _fill_m2x_create_edit_option(self):
-        """Adds every missing field option for model ``self``"""
+        :param bool own: if True, creates options for model's fields
+        :param bool comodels: if True, creates options for fields where ``self`` is comodel
+        """
         self.ensure_one()
-        existing = self.m2x_create_edit_option_ids.mapped("field_id")
-        valid = self.field_id.filtered(lambda f: f.ttype in ("many2many", "many2one"))
-        vals = [(0, 0, {"field_id": f.id}) for f in valid - existing]
-        self.write({"m2x_create_edit_option_ids": vals})
-
-
-class IrModelFields(models.Model):
-    _inherit = "ir.model.fields"
-
-    @api.model
-    def name_search(self, name="", args=None, operator="ilike", limit=100):
-        res = super().name_search(name, args, operator, limit)
-        if not (name and self.env.context.get("search_by_technical_name")):
-            return res
-        domain = list(args or []) + [("name", operator, name)]
-        new_fids = self.search(domain, limit=limit).ids
-        for fid in [x[0] for x in res]:
-            if fid not in new_fids:
-                new_fids.append(fid)
-        if limit and limit > 0:
-            new_fids = new_fids[:limit]
-        return self.browse(new_fids).sudo().name_get()
+        todo = set()
+        if own:
+            exist = self.m2x_option_ids.mapped("field_id")
+            valid = self.field_id.filtered("can_have_options")
+            todo.update((valid - exist).ids)
+        if comodels:
+            exist = self.m2x_comodels_option_ids.mapped("field_id")
+            valid = self.comodel_field_ids.filtered("can_have_options")
+            todo.update((valid - exist).ids)
+        if todo:
+            self.env["m2x.create.edit.option"].create([{"field_id": i} for i in todo])