-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] stock_available_exclude_location: add new module #2153
base: 14.0
Are you sure you want to change the base?
[14.0][ADD] stock_available_exclude_location: add new module #2153
Conversation
af5cbf4
to
f0c802d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[FUNCTIONAL REVIEW]
The test is conducted to check if the configuration is applied to the child locations; if so, those locations are excluded.
Is this the expected behavior? Wouldn't it be better to exclude all child locations from the selected location? Alternatively, could there be two fields:
- Unique
- Parent and Children
f0c802d
to
c5bd70a
Compare
Makes sense, we add the module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Review
a368b3d
to
670ad36
Compare
670ad36
to
1c665c6
Compare
This looks great. @WesleyOliveira98 I'm just wondering if those excluded locations should be excluded at warehouse level, why not defining those locations outside the warehouse view location ? |
@rousseldenis We thought about defining it in the warehouse as it was the model that made the most sense for defining location rules, where do you suggest we place this configuration? |
No, I wanted to say, from a functional point of view about locations that should be excluded from available quantities. |
1c665c6
to
cad63b0
Compare
cad63b0
to
7f1bf7d
Compare
@rousseldenis I change the configuration of the excluded locations to inventory settings based on the company: Could you review it please? |
Ok, but you didn't answer my question 😅 |
Sure, this way it is much easier to deal with this specific problem of not counting the quantities of a location, but we have some cases such as not counting a specific shelf in stock, or excluding pre-production and post -production when using MRP with 3 steps, and using the |
ping @OCA/stock-weighing-maintainers @rousseldenis @marcelsavegnago @kaynnan @douglascstd |
Ticket: HT00837
This module allow defining excluded locations for product availability.
Select the excluded locations in Inventory Settings:
Now the quantity in these locations is excluded of product availability
Even when we have quantities of this product in the locations we marked to exclude
cc: @marcelsavegnago @kaynnan @douglascstd