[MIG] attachment_delete_restrict: Migration to 19.0

- Remove the self.env.su condition in unlink, since it is always called with sudo() in Odoo 19.
https://github.com/odoo/odoo/blob/98bae80f57733162c67593539ef47dfd0c6d8797/addons/mail/controllers/attachment.py#L98

Author: AungKoKoLin1997

attachment_delete_restrict/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
     "name": "Restrict Deletion of Attachments",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "depends": [
         "base",
         "base_setup",

attachment_delete_restrict/models/ir_attachment.py

@@ -1,8 +1,7 @@
 # Copyright 2021 Quartile (https://www.quartile.co)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-
-from odoo import _, models
+from odoo import SUPERUSER_ID, models
 from odoo.exceptions import ValidationError
 
 
@@ -29,7 +28,7 @@ def _check_delete_attachment(self, model=None):
 
     def _raise_delete_attachment_error(self, allowed_users):
         raise ValidationError(
-            _(
+            self.env._(
                 "You are not allowed to delete this attachment.\n\nUsers with "
                 "the delete permission:\n%s"
             )
@@ -42,7 +41,7 @@ def _check_owner_delete_attachment(self):
             or self.env.user.has_group("base.group_system")
         ):
             return self._raise_delete_attachment_error(
-                self.create_uid | self.env.ref("base.group_system").users
+                self.create_uid | self.env.ref("base.group_system").user_ids
             )
 
     def _check_custom_delete_attachment(self, model=None, allow_owner_and_admin=False):
@@ -59,12 +58,12 @@ def _check_custom_delete_attachment(self, model=None, allow_owner_and_admin=Fals
         if allow_owner_and_admin:
             users += self.create_uid
             groups += self.env.ref("base.group_system")
-        allowed_users = groups.users | users
+        allowed_users = groups.user_ids | users
         if self.env.user not in allowed_users:
             return self._raise_delete_attachment_error(allowed_users)
 
     def unlink(self):
-        if self.env.su:
+        if self.env.uid == SUPERUSER_ID:
             return super().unlink()
         res_models = list(set(self.filtered("res_model").mapped("res_model")))
         if res_models:

attachment_delete_restrict/models/ir_model.py

@@ -1,7 +1,7 @@
 # Copyright 2021 Quartile (https://www.quartile.co)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import fields, models
+from odoo import api, fields, models
 
 RESTRICT_DELETE_ATTACH = [
     ("default", "Use global configuration"),
@@ -43,6 +43,7 @@ class IrModel(models.Model):
         "model.",
     )
 
+    @api.onchange("restrict_delete_attachment")
     def _onchange_restrict_delete_attachment(self):
         if self.restrict_delete_attachment not in ["custom", "owner_custom"]:
             self.delete_attachment_group_ids = False

attachment_delete_restrict/tests/test_attachment_delete_restrict.py

@@ -85,7 +85,7 @@ def setUpClass(cls):
             {
                 "name": "test owner user",
                 "login": "[email protected]",
-                "groups_id": [
+                "group_ids": [
                     Command.set(
                         [
                             cls.env.ref("base.group_user").id,
@@ -99,7 +99,7 @@ def setUpClass(cls):
             {
                 "name": "test user",
                 "login": "[email protected]",
-                "groups_id": [
+                "group_ids": [
                     Command.set(
                         [
                             cls.env.ref("base.group_user").id,
@@ -113,7 +113,7 @@ def setUpClass(cls):
             {
                 "name": "User admin",
                 "login": "[email protected]",
-                "groups_id": [
+                "group_ids": [
                     Command.set(
                         [
                             cls.env.ref("base.group_system").id,