[MIG] base_model_restrict_update: Migration to 19.0

Author: AungKoKoLin1997

base_model_restrict_update/README.rst

@@ -21,22 +21,22 @@ Update Restrict Model
     :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
     :alt: License: LGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github
-    :target: https://github.com/OCA/server-tools/tree/18.0/base_model_restrict_update
+    :target: https://github.com/OCA/server-tools/tree/19.0/base_model_restrict_update
     :alt: OCA/server-tools
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_model_restrict_update
+    :target: https://translation.odoo-community.org/projects/server-tools-19-0/server-tools-19-0-base_model_restrict_update
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
 This module adds the following features:
 
-- The ability to limit the update permissions for a model to certain
-  groups
-- The ability to revoke update permissions for specific users
+-  The ability to limit the update permissions for a model to certain
+   groups
+-  The ability to revoke update permissions for specific users
 
 **Table of contents**
 
@@ -69,7 +69,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-tools/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20base_model_restrict_update%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20base_model_restrict_update%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -84,19 +84,19 @@ Authors
 Contributors
 ------------
 
-- `Quartile <https://www.quartile.co>`__:
+-  `Quartile <https://www.quartile.co>`__:
 
-  - Yoshi Tashiro <[email protected]>
+   -  Yoshi Tashiro <[email protected]>
 
-- Ecosoft
+-  Ecosoft
 
-  - Kitti U. <[email protected]>
+   -  Kitti U. <[email protected]>
 
 Other credits
 -------------
 
-- This module borrows the idea from 'Moises Lopez
-  <https://odoo-community.org/groups/contributors-15/contributors-161807>'
+-  This module borrows the idea from 'Moises Lopez
+   <https://odoo-community.org/groups/contributors-15/contributors-161807>'
 
 Maintainers
 -----------
@@ -122,6 +122,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-yostashiro| |maintainer-aungkokolin1997| 
 
-This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/18.0/base_model_restrict_update>`_ project on GitHub.
+This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/19.0/base_model_restrict_update>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

base_model_restrict_update/__manifest__.py

@@ -2,7 +2,7 @@
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl).
 {
     "name": "Update Restrict Model",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "depends": ["base_setup"],
     "website": "https://github.com/OCA/server-tools",
     "author": "Odoo Community Association (OCA), Quartile",

base_model_restrict_update/models/ir_model_access.py

@@ -3,7 +3,6 @@
 
 from odoo import api, models
 from odoo.exceptions import AccessError
-from odoo.tools.translate import _
 
 
 class IrModelAccess(models.Model):
@@ -72,7 +71,10 @@ def check(self, model, mode="read", raise_exception=True):
             if not raise_exception:
                 return False
             raise AccessError(
-                _("You are only allowed to read this record. (%(model)s - %(mode)s)")
-                % {"model": model, "mode": mode}
+                self.env._(
+                    "You are only allowed to read this record. (%(model)s - %(mode)s)"
+                ),
+                model=model,
+                mode=mode,
             )
         return res

base_model_restrict_update/models/res_users.py

@@ -1,7 +1,7 @@
 # Copyright 2021-2024 Quartile (https://www.quartile.co)
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError
 
 
@@ -14,8 +14,11 @@ class ResUsers(models.Model):
         "records.",
     )
 
-    @api.constrains("is_readonly_user", "groups_id")
+    @api.constrains("is_readonly_user", "group_ids")
     def _check_is_readonly_user(self):
         for user in self:
-            if user.has_group("base.group_system") and user.is_readonly_user:
-                raise UserError(_("You cannot make the admin user read-only."))
+            if (
+                user in self.env.ref("base.group_system").user_ids
+                and user.is_readonly_user
+            ):
+                raise UserError(self.env._("You cannot make the admin user read-only."))

base_model_restrict_update/static/description/index.html

@@ -374,7 +374,7 @@ <h1>Update Restrict Model</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:a0a6bc8d798dea0412aeb5e7c9f5fe8f7aec4d6d0e40c7e0d2c19ffc07bbb2cb
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/license-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-tools/tree/18.0/base_model_restrict_update"><img alt="OCA/server-tools" src="https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_model_restrict_update"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-tools&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/license-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-tools/tree/19.0/base_model_restrict_update"><img alt="OCA/server-tools" src="https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-tools-19-0/server-tools-19-0-base_model_restrict_update"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-tools&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds the following features:</p>
 <ul class="simple">
 <li>The ability to limit the update permissions for a model to certain
@@ -420,7 +420,7 @@ <h2><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/server-tools/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/server-tools/issues/new?body=module:%20base_model_restrict_update%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/server-tools/issues/new?body=module:%20base_model_restrict_update%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -462,7 +462,7 @@ <h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainers</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/yostashiro"><img alt="yostashiro" src="https://github.com/yostashiro.png?size=40px" /></a> <a class="reference external image-reference" href="https://github.com/aungkokolin1997"><img alt="aungkokolin1997" src="https://github.com/aungkokolin1997.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-tools/tree/18.0/base_model_restrict_update">OCA/server-tools</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-tools/tree/19.0/base_model_restrict_update">OCA/server-tools</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

base_model_restrict_update/tests/test_base_model_restrict_update.py

@@ -15,7 +15,20 @@ def setUpClass(cls):
         cls.group_partner_update = cls.env["res.groups"].create(
             {"name": "Partner Update Group"}
         )
-        cls.test_user = cls.env["res.users"].create({"name": "test", "login": "test"})
+        cls.test_user = cls.env["res.users"].create(
+            {
+                "name": "test",
+                "login": "test",
+                "group_ids": [
+                    Command.set(
+                        [
+                            cls.env.ref("base.group_user").id,
+                            cls.env.ref("base.group_partner_manager").id,
+                        ]
+                    )
+                ],
+            }
+        )
         cls.partner_model_with_test_user = cls.env["res.partner"].with_user(
             cls.test_user.id
         )
@@ -43,7 +56,7 @@ def test_with_model_restriction(self):
             self.test_partner_with_test_user.write({"name": "baz"})
         with self.assertRaises(AccessError):
             self.test_partner_with_test_user.unlink()
-        self.test_user.groups_id = [Command.link(self.group_partner_update.id)]
+        self.test_user.group_ids = [Command.link(self.group_partner_update.id)]
         self.partner_model_with_test_user.create({"name": "bar"})
         self.test_partner_with_test_user.write({"name": "baz"})
         self.test_partner_with_test_user.unlink()
@@ -59,7 +72,7 @@ def test_with_user_readonly(self):
         # To confirm that is_readonly_user prevails
         self.model_partner.restrict_update = True
         self.model_partner.update_allowed_group_ids = self.group_partner_update
-        self.test_user.groups_id = [Command.link(self.group_partner_update.id)]
+        self.test_user.group_ids = [Command.link(self.group_partner_update.id)]
         with self.assertRaises(AccessError):
             self.partner_model_with_test_user.create({"name": "bar"})
         with self.assertRaises(AccessError):
@@ -82,10 +95,10 @@ def test_with_user_readonly(self):
 
     def test_set_user_readonly(self):
         group_system_id = self.env.ref("base.group_system").id
-        self.test_user.groups_id = [Command.link(group_system_id)]
+        self.test_user.group_ids = [Command.link(group_system_id)]
         with self.assertRaises(UserError):
             self.test_user.is_readonly_user = True
-        self.test_user.groups_id = [Command.unlink(group_system_id)]
+        self.test_user.group_ids = [Command.unlink(group_system_id)]
         self.test_user.is_readonly_user = True
         with self.assertRaises(UserError):
-            self.test_user.groups_id = [Command.link(group_system_id)]
+            self.test_user.group_ids = [Command.link(group_system_id)]