[17.0][MIG] users_ldap_groups: Migration to 17.0 #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2024
|
Is this still draft? Please include #596 |
…o a transientmodel
…p beneath the module's name in kanban view
Also improve tests and handle new warning
Currently translated at 100.0% (26 of 26 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/es/
Currently translated at 100.0% (26 of 26 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/it/
res.company.ldap.operator operators should be private methods; public methods allow arbitrary LDAP queries via JSON-API
Currently translated at 100.0% (26 of 26 strings) Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/pt_BR/
Co-authored-by: Hpar <[email protected]>
The group mapping in query mode fails if LDAP returns binary data in any of the fields. This adds a function that handles such situation by base64 encoding it. The new test test_users_ldap_groups_ldap_returns_binary_data covers the common case where LDAP return binary data in thumbnailPhoto.
ryanc-me
force-pushed
the
17.0-mig-users_ldap_groups
branch
from
1a89c3b
to
59ee980
Compare
|
@pedrobaeza what is the policy re codecov failure for migrations? |
|
It's not mandatory, so don't worry too much in migrations. |
|
Thanks Pedro, that's good to know. @cvinh any chance you could review this one also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.