[MIG] purchase_delivery_split_date: Migration to 19.0

Author: Tatiana Deribina

purchase_delivery_split_date/README.rst

@@ -21,13 +21,13 @@ Purchase Delivery Split Date
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github
-    :target: https://github.com/OCA/purchase-workflow/tree/18.0/purchase_delivery_split_date
+    :target: https://github.com/OCA/purchase-workflow/tree/19.0/purchase_delivery_split_date
     :alt: OCA/purchase-workflow
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_delivery_split_date
+    :target: https://translation.odoo-community.org/projects/purchase-workflow-19-0/purchase-workflow-19-0-purchase_delivery_split_date
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -91,7 +91,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/purchase-workflow/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_delivery_split_date%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_delivery_split_date%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -120,6 +120,12 @@ Contributors
 - Denis Roussel <[email protected]>
 - Jacques-Etienne Baudoux (BCIM) <[email protected]>
 
+Other credits
+-------------
+
+The migration of this module from 18.0 to 19.0 was financially supported
+by SprintIT Ltd.
+
 Maintainers
 -----------
 
@@ -133,6 +139,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/18.0/purchase_delivery_split_date>`_ project on GitHub.
+This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/19.0/purchase_delivery_split_date>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

purchase_delivery_split_date/__manifest__.py

@@ -5,7 +5,7 @@
 
 {
     "name": "Purchase Delivery Split Date",
-    "version": "18.0.2.0.1",
+    "version": "19.0.1.0.0",
     "summary": "Allows Purchase Order you confirm to generate one Incoming "
     "Shipment for each expected date indicated in the Purchase Order Lines",
     "author": (

purchase_delivery_split_date/models/purchase_order_line.py

@@ -3,11 +3,10 @@
 # Copyright 2021 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
-from itertools import groupby
-
 import pytz
 
 from odoo import fields, models
+from odoo.tools import groupby
 
 
 class PurchaseOrderLine(models.Model):
@@ -22,11 +21,11 @@ def _purchase_split_date_get_group_keys(self, picking):
         can add additional keys or replace them by others.
         """
         tz = self.order_id.picking_type_id.warehouse_id.partner_id.tz
-        wh_tz = pytz.timezone(tz or self.env.user.tz or "UTC")
+        wh_tz = pytz.timezone(tz) if tz else self.env.tz
         date_planned_tz = self.date_planned.astimezone(pytz.utc).astimezone(wh_tz)
         date = date_planned_tz.date()
         # Split date value to obtain only the attributes year, month and day
-        key = ({"date_planned": fields.Date.to_string(date)},)
+        key = (("date_planned", fields.Date.to_string(date)),)
         return key
 
     def _purchase_split_date_get_sorted_keys(self):
@@ -43,7 +42,7 @@ def _create_stock_moves(self, picking):
             # A picking should be provided
             return super()._create_stock_moves(picking)
         moves = self.env["stock.move"]
-        tz = picking.picking_type_id.warehouse_id.partner_id.tz or self.env.user.tz
+        tz = picking.picking_type_id.warehouse_id.partner_id.tz
         # Group the order lines by group key
         order_lines = sorted(
             self.filtered(

purchase_delivery_split_date/models/stock_move.py

@@ -4,28 +4,28 @@
 import pytz
 
 from odoo import fields, models
-from odoo.osv import expression
+from odoo.fields import Domain
 from odoo.tools import groupby
 
 
 class StockMove(models.Model):
     _inherit = "stock.move"
 
     def _purchase_split_date_get_group_keys(self):
-        tz = self.picking_type_id.warehouse_id.partner_id.tz or self.env.user.tz
-        wh_tz = pytz.timezone(tz or "UTC")
+        tz = self.picking_type_id.warehouse_id.partner_id.tz
+        wh_tz = pytz.timezone(tz) if tz else self.env.tz
         date_planned_tz = self.date_deadline.astimezone(pytz.utc).astimezone(wh_tz)
         date = date_planned_tz.date()
         # Split date value to obtain only the attributes year, month and day
-        key = ({"date_planned": fields.Date.to_string(date)},)
+        key = (("date_planned", fields.Date.to_string(date)),)
         return key
 
     def _search_picking_for_assignation_domain(self):
         domain = super()._search_picking_for_assignation_domain()
         if self.env.context.get("purchase_delivery_split_date"):
             key = self._purchase_split_date_get_group_keys()
-            tz = self.picking_type_id.warehouse_id.partner_id.tz or self.env.user.tz
-            domain = expression.AND(
+            tz = self.picking_type_id.warehouse_id.partner_id.tz
+            domain = Domain.AND(
                 [domain, self.picking_id._purchase_split_date_assign_domain(key, tz)]
             )
         return domain
@@ -70,5 +70,6 @@ def _get_new_picking_values(self):
         if self.env.context.get("purchase_delivery_split_date") and not vals.get(
             "partner_id"
         ):
-            vals["partner_id"] = fields.first(self.purchase_line_id.partner_id).id
+            partners = self.purchase_line_id.partner_id
+            vals["partner_id"] = next(iter(partners), partners).id
         return vals

purchase_delivery_split_date/models/stock_picking.py

@@ -13,8 +13,8 @@ class StockPicking(models.Model):
 
     @api.model
     def _purchase_split_date_assign_domain(self, key, tz):
-        date = key[0].get("date_planned")
-        wh_tz = pytz.timezone(tz or "UTC")
+        date = key[0][1]
+        wh_tz = pytz.timezone(tz) if tz else self.env.tz
         # The date is in local time
         dt_start_tz = wh_tz.localize(fields.Datetime.to_datetime(date))
         dt_start = dt_start_tz.astimezone(pytz.utc).replace(tzinfo=None)

purchase_delivery_split_date/readme/CREDITS.md

@@ -0,0 +1,2 @@
+The migration of this module from 18.0 to 19.0 was financially supported
+by SprintIT Ltd.

purchase_delivery_split_date/static/description/index.html

@@ -374,7 +374,7 @@ <h1>Purchase Delivery Split Date</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:c31a6e3528da8fa59cb4c57c78216193c920b907b5da75687b40cfff83a3cfd8
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/purchase-workflow/tree/18.0/purchase_delivery_split_date"><img alt="OCA/purchase-workflow" src="https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_delivery_split_date"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/purchase-workflow/tree/19.0/purchase_delivery_split_date"><img alt="OCA/purchase-workflow" src="https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/purchase-workflow-19-0/purchase-workflow-19-0-purchase_delivery_split_date"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>When this module is installed, each Purchase Order you confirm will
 generate one Incoming Shipment for each schedule date indicated in the
 Purchase Order Lines.</p>
@@ -399,7 +399,8 @@ <h1>Purchase Delivery Split Date</h1>
 <li><a class="reference internal" href="#credits" id="toc-entry-7">Credits</a><ul>
 <li><a class="reference internal" href="#authors" id="toc-entry-8">Authors</a></li>
 <li><a class="reference internal" href="#contributors" id="toc-entry-9">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="toc-entry-10">Maintainers</a></li>
+<li><a class="reference internal" href="#other-credits" id="toc-entry-10">Other credits</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-11">Maintainers</a></li>
 </ul>
 </li>
 </ul>
@@ -446,7 +447,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/purchase-workflow/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_delivery_split_date%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_delivery_split_date%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -475,16 +476,21 @@ <h3><a class="toc-backref" href="#toc-entry-9">Contributors</a></h3>
 <li>Jacques-Etienne Baudoux (BCIM) &lt;<a class="reference external" href="mailto:je&#64;bcim.be">je&#64;bcim.be</a>&gt;</li>
 </ul>
 </div>
+<div class="section" id="other-credits">
+<h3><a class="toc-backref" href="#toc-entry-10">Other credits</a></h3>
+<p>The migration of this module from 18.0 to 19.0 was financially supported
+by SprintIT Ltd.</p>
+</div>
 <div class="section" id="maintainers">
-<h3><a class="toc-backref" href="#toc-entry-10">Maintainers</a></h3>
+<h3><a class="toc-backref" href="#toc-entry-11">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
 </a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/purchase-workflow/tree/18.0/purchase_delivery_split_date">OCA/purchase-workflow</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/purchase-workflow/tree/19.0/purchase_delivery_split_date">OCA/purchase-workflow</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

purchase_delivery_split_date/tests/test_purchase_delivery.py

@@ -1,16 +1,17 @@
 # Copyright 2014-2016 Numérigraphe SARL
 # Copyright 2017 ForgeFlow, S.L.
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
 from freezegun import freeze_time
 
 from odoo import Command
 from odoo.fields import Datetime
 from odoo.tests import Form
 
-from odoo.addons.base.tests.common import BaseCommon
+from odoo.addons.purchase_stock.tests.common import PurchaseTestCommon
 
 
-class TestDeliverySingle(BaseCommon):
+class TestDeliverySingle(PurchaseTestCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -57,12 +58,12 @@ def setUpClass(cls):
 
         cls.po = cls.env["purchase.order"].create(
             {
-                "partner_id": cls.env.ref("base.res_partner_3").id,
+                "partner_id": cls.partner_1.id,
                 "order_line": [
                     Command.create(
                         {
                             "product_id": cls.p1.id,
-                            "product_uom": cls.p1.uom_id.id,
+                            "product_uom_id": cls.p1.uom_id.id,
                             "name": cls.p1.name,
                             "price_unit": cls.p1.standard_price,
                             "date_planned": cls.date_sooner,
@@ -72,7 +73,7 @@ def setUpClass(cls):
                     Command.create(
                         {
                             "product_id": cls.p2.id,
-                            "product_uom": cls.p2.uom_id.id,
+                            "product_uom_id": cls.p2.uom_id.id,
                             "name": cls.p2.name,
                             "price_unit": cls.p2.standard_price,
                             "date_planned": cls.date_sooner,
@@ -82,7 +83,7 @@ def setUpClass(cls):
                     Command.create(
                         {
                             "product_id": cls.p1.id,
-                            "product_uom": cls.p1.uom_id.id,
+                            "product_uom_id": cls.p1.uom_id.id,
                             "name": cls.p1.name,
                             "price_unit": cls.p1.standard_price,
                             "date_planned": cls.date_sooner,
@@ -120,7 +121,7 @@ def test_adding_line(self):
         # We first add a seller to the product
         self.env["product.supplierinfo"].create(
             {
-                "partner_id": self.env.ref("base.res_partner_3").id,
+                "partner_id": self.partner_1.id,
                 "product_tmpl_id": self.p1.product_tmpl_id.id,
             }
         )
@@ -279,7 +280,7 @@ def test_purchase_line_created_after_confirm(self):
             Command.create(
                 {
                     "product_id": self.p3.id,
-                    "product_uom": self.p3.uom_id.id,
+                    "product_uom_id": self.p3.uom_id.id,
                     "name": self.p3.name,
                     "price_unit": self.p3.standard_price,
                     "date_planned": new_date,
@@ -302,19 +303,27 @@ def test_purchase_line_date_change_tz_aware(self):
         self.po.button_confirm()
         line1 = self.po.order_line[0]
         line2 = self.po.order_line[1]
-        self.env.user.tz = "Europe/Brussels"
+        brussels_context = {
+            "tz": "Europe/Brussels",
+        }
         self.assertEqual(len(self.po.picking_ids), 1)
-        line1.write({"date_planned": "2021-05-05 03:00:00"})
+        line1.with_context(**brussels_context).write(
+            {"date_planned": "2021-05-05 03:00:00"}
+        )
         self.assertEqual(len(self.po.picking_ids), 2)
         # Time difference of at least +1 so  should be same day (1 picking)
-        line2.write({"date_planned": "2021-05-04 23:00:00"})
+        line2.with_context(**brussels_context).write(
+            {"date_planned": "2021-05-04 23:00:00"}
+        )
         self.assertEqual(len(self.po.picking_ids), 1)
 
-        self.env.user.tz = "Etc/UTC"
+        utc_context = {
+            "tz": "Etc/UTC",
+        }
         # No time difference so will be another day (2 pickings)
-        line1.write({"date_planned": "2021-05-05 03:00:00"})
+        line1.with_context(**utc_context).write({"date_planned": "2021-05-05 03:00:00"})
         self.assertEqual(len(self.po.picking_ids), 2)
-        line2.write({"date_planned": "2021-05-04 23:00:00"})
+        line2.with_context(**utc_context).write({"date_planned": "2021-05-04 23:00:00"})
         self.assertEqual(len(self.po.picking_ids), 2)
 
     def test_create_from_form(self):
@@ -332,7 +341,7 @@ def test_po_with_services(self):
             {
                 "order_id": self.po.id,
                 "product_id": self.service_1.id,
-                "product_uom": self.service_1.uom_id.id,
+                "product_uom_id": self.service_1.uom_id.id,
                 "name": self.service_1.name,
                 "price_unit": self.service_1.standard_price,
                 "date_planned": self.date_later,