Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not notify maintainers if the maintainers key of a module is not a list of strings #126

Open
sbidoul opened this issue Aug 13, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@sbidoul
Copy link
Member

sbidoul commented Aug 13, 2020

Example: OCA/hr#869 (comment)

@sbidoul sbidoul added the bug Something isn't working label Aug 13, 2020
@Khalid-SerpentCS
Copy link

Example: OCA/hr#869 (comment)

Solved!

@bodedra
Copy link
Member

bodedra commented Aug 13, 2020

Example: OCA/hr#869 (comment)

Solved!

@Khalid-SerpentCS You have corrected maintainers key for that specific module, not for a bot issue.

This is a bug:

Screenshot from 2020-08-13 14-21-15

@luisg123v
Copy link

Is it expected for the bot to notify maintainers when the PR is not green yet?

If no,, this could be solved by a lint check. If yes, it needs to be solved here, but the lint could still be useful.

@legalsylvain
Copy link
Collaborator

Is it expected for the bot to notify maintainers when the PR is not green yet?

Well I think so. But could you open a dedicated issue if you think it's necessary ?

@sbidoul
Copy link
Member Author

sbidoul commented Jun 5, 2023

Is it expected for the bot to notify maintainers when the PR is not green yet?

Yes that's how it was designed. Personally I liked to be notified as soon as the PR is open. It allows me to give early guidance if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants