Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field #4459

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[14.0][IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field #4459

merged 1 commit into from
Dec 11, 2024

Conversation

toita86
Copy link

@toita86 toita86 commented Nov 25, 2024 •
edited
Loading

improvements for is_unsolved field

  • Changed placement to see the label better
  • When a invoice is duplicated the field is set to
    false. This behavior that was not present
    before this PR

@toita86 toita86 force-pushed the 14.0-IMP-l10n_it_ricevute_bancarie-toita86 branch 3 times, most recently from 40c5426 to 221e4b4 Compare November 26, 2024 08:41
@toita86 toita86 changed the title [IMP]l10n_it_ricevute_bancarie: improved placement of is_unsolved field [14.0][IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field Nov 26, 2024
@toita86 toita86 force-pushed the 14.0-IMP-l10n_it_ricevute_bancarie-toita86 branch from 221e4b4 to 0117754 Compare November 26, 2024 08:44
@francesco-ooops francesco-ooops mentioned this pull request Nov 26, 2024
Open
2 tasks
@francesco-ooops francesco-ooops linked an issue Nov 26, 2024 that may be closed by this pull request
RiBa: is_unsolved field fixes #4460
Open
2 tasks
andreampiovesana
andreampiovesana approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-ooops
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@francesco-ooops The rebase process failed, because command git rebase origin/14.0 failed with output:

Rebasing (1/1)
Auto-merging l10n_it_ricevute_bancarie/README.rst
CONFLICT (content): Merge conflict in l10n_it_ricevute_bancarie/README.rst
Auto-merging l10n_it_ricevute_bancarie/models/account.py
Auto-merging l10n_it_ricevute_bancarie/readme/CONTRIBUTORS.rst
CONFLICT (content): Merge conflict in l10n_it_ricevute_bancarie/readme/CONTRIBUTORS.rst
Auto-merging l10n_it_ricevute_bancarie/static/description/index.html
CONFLICT (content): Merge conflict in l10n_it_ricevute_bancarie/static/description/index.html
Auto-merging l10n_it_ricevute_bancarie/views/account_view.xml
error: could not apply 011775461... [IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 011775461... [IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field

@SirAionTech SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Dec 9, 2024
@toita86
[IMP]l10n_it_ricevute_bancarie: improvements for is_unsolved field
a394531 
- Changed placement to see the label better
- When a invoice is duplicated the field is set to
  false. This behavior that was not present
  before this commit
@toita86 toita86 force-pushed the 14.0-IMP-l10n_it_ricevute_bancarie-toita86 branch from 0117754 to a394531 Compare December 9, 2024 11:45
@francesco-ooops francesco-ooops removed the needs fixing Has conflicts or is failing mandatory CI checks label Dec 9, 2024
francesco-ooops
francesco-ooops approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok

@odooNextev che ne pensi?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Dec 9, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

GSLabIt
GSLabIt approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code

@francesco-ooops
Copy link
Contributor

@SirAionTech le review ci sono, mergiamo?

@SirAionTech
Copy link
Contributor

@SirAionTech le review ci sono, mergiamo?

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-4459-by-SirAionTech-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a2fbf95. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 25a0e23 into OCA:14.0 Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

Assignees
No one assigned
Labels
14.0 approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RiBa: is_unsolved field fixes
7 participants
@toita86 @francesco-ooops @OCA-git-bot @SirAionTech @GSLabIt @andreampiovesana @MaurizioPellegrinet