Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] hr_contract_employee_calendar_planning #1324

Merged

Conversation

jonasbuchholz
Copy link
Contributor

Migration to 16.0

@jonasbuchholz jonasbuchholz force-pushed the 16.0-mig_hr_contract_employee_calendar_planning branch from e844150 to 8181060 Compare December 18, 2023 14:16
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@github-actions github-actions bot closed this Jun 2, 2024
@etobella etobella reopened this Jul 8, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks good to me! However, in the migration proccess code has been added, such as overwitten create method and modifications to hr.contract.history view, in addition to the already modified hr.contrat view. The overwritten create method should be tested in order to pass all checks. Can you add that test?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
@ChristophAbenthungCibex ChristophAbenthungCibex force-pushed the 16.0-mig_hr_contract_employee_calendar_planning branch from 8181060 to 591e1a3 Compare November 26, 2024 06:57
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2024
@pedrobaeza
Copy link
Member

/ocabot migration hr_contract_employee_calendar_planning

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 26, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 26, 2024
28 tasks
@ChristophAbenthungCibex ChristophAbenthungCibex force-pushed the 16.0-mig_hr_contract_employee_calendar_planning branch from 591e1a3 to da038b2 Compare November 26, 2024 07:07
@ChristophAbenthungCibex
Copy link
Contributor

@pedrobaeza
Can you merge it please? Or is there something left todo?

@pedrobaeza
Copy link
Member

I don't use this module. @etobella should say. And each PR requires 2 approvals, and one from PSC:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1324-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 60aec3c into OCA:16.0 Dec 3, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e5cc480. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants