Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 16.0 #213

Open
5 of 6 tasks
sbidoul opened this issue Oct 3, 2022 · 28 comments
Open
5 of 6 tasks

Migration to version 16.0 #213

sbidoul opened this issue Oct 3, 2022 · 28 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@sbidoul sbidoul added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 3, 2022
@sbidoul sbidoul added this to the 16.0 milestone Oct 3, 2022
@satriani-vai
Copy link

Any progress?

@pedrobaeza
Copy link
Member

Not yet. If you want to fund the migration, contact any of the contributors of the modules.

@lijoantony
Copy link

I believe a PR is underway #249

@pedrobaeza
Copy link
Member

That PR is invalid with red CI and even not installing (and no commit history, but that's just a technical detail).

@jasonribble
Copy link

Any way I can help? I'm new to OCA modules though I'd be happy to put my energy into this module.

@pedrobaeza
Copy link
Member

You can try to migrate it with the guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0, but the hard part here is that you should convert JS code to OWL, and that's not an easy task I'm afraid.

@jasonribble
Copy link

Is anyone working on it yet?

@pedrobaeza
Copy link
Member

Nobody has expressed interest yet, and the existing PR is not working at all and no more answers from the original author.

@pedrobaeza pedrobaeza pinned this issue Jul 11, 2023
@vancouver29
Copy link

vancouver29 commented Jul 26, 2023

Hi all, I will take time to migrate these 2 modules if no one has started yet?

@jasonribble
Copy link

How exciting! I'm unsure how I can help but feel free to reach out?

@agent-z28
Copy link

@vancouver29 did you start already something ?

@vancouver29
Copy link

vancouver29 commented Sep 4, 2023

@agent-z28 I just started; it will take time. The 2 OCA dependencies, web_drop_target and mail_preview_base, should also be migrated into v16. As far as I know, the OCA Module web_drop-target functionality should now be in Odoo core.

@agent-z28
Copy link

@vancouver29 thats great! I know that from Elego in Berlin they are planing to work on that topic!
I send them the Link again, to contact you and collaborate on this topic.

@len-foss
Copy link

len-foss commented Sep 4, 2023

I tested some things, and I'm really not sure of the best approach to port most of the js.
There's a lot of work in porting mail_preview_base (OCA/social#1183); I haven't even checked web_drop_target (OCA/web#2528).

It seems that some of the functionality in core that should be reusable is fairly coupled to the way it's used in enterprise code making it a bit awkward. There are some design decisions to take, in any case.

@vancouver29
Copy link

vancouver29 commented Sep 14, 2023

@agent-z28 @len-foss FYI, the dms module is nearly complete. We no longer need the two OCA modules web_drop_target and mail_preview_base, because Odoo Core 16 provides the functionalities offered by these two OCA modules. When the time comes, I will create a pull request as soon as possible.

@len-foss
Copy link

@vancouver29 Nice! Don't hesitate to ping me before it's entirely finished, I'm already running a 16 test instance with a quickly hacked branch (without js preview) so I can also check everything migrates properly and do some cleanup if needed.

In the meantime I've worked on some related features:

  • [16.0] pdf content indexing: PyMupdf + Tesseract knowledge#431 which contains indexation of content with pyMupdf and tesseract for OCR (there may be other more interesting options to consider for OCR)
  • a related on indexed content so that documents can be searched on their content, taking advantage of that indexation
  • automatic tagging of documents by fuzzy-matching tag names with indexed content (and similar a categorization)
  • and a few miscellaneous features

(I've made some tests with PrivateGPT that didn't really work out with non-English language, but that could be something really useful to integrate, I'd be interested to know if anybody else is working on something like this.)

Let me know if I should make a PR for any of it.

@agent-z28
Copy link

agent-z28 commented Sep 15, 2023

@len-foss please contact me about AI related document processing, since we have this topic in a quite high priority and did some research based on this! We should join efforts and provide a good solution for the oca

@vancouver29
Copy link

vancouver29 commented Sep 18, 2023

@agent-z28 @len-foss and OCA community FYI, I created a PR for the DMS module. PR 262

@vancouver29
Copy link

@pedrobaeza @marylla FYI #262 (comment)

@mpoli
Copy link

mpoli commented Nov 30, 2023

As per https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list are we missing dms_attachment_link in the list of modules?

I have installed the dms app but I cannot see the functionality described in that module happening without it.

@pedrobaeza
Copy link
Member

It's not migrated. Being in the list or not doesn't change this question.

@mpoli
Copy link

mpoli commented Nov 30, 2023

Thanks for the prompt reply. I was trying to understand wether the functionality provided by that module will be made available somehow in 16, and thought that this section of that referred document might be of help, as I didn't see it in the list, even if crossed out:

So that doesn't mean the module is not needed in new version. This has to be checked by any contributor. If finally not needed, then the line for the module should be on the migration issue, but it should be crossed out by any of the maintainers, explaining the reason why it's not needed.

But what I am searching is the functionality that the dms_attachment_link module provides in v15 for Odoo 16. That is, being able to select a file that is in DMS as an attachment to chatter, email, SMS etc especially in sales and CRM so we can send clients information that is frequently requested.

Will there be any way to do that in 16?

@pedrobaeza
Copy link
Member

Someone needs to migrate the module.

@R3D2
Copy link

R3D2 commented Mar 19, 2024

Thanks for the prompt reply. I was trying to understand wether the functionality provided by that module will be made available somehow in 16, and thought that this section of that referred document might be of help, as I didn't see it in the list, even if crossed out:

So that doesn't mean the module is not needed in new version. This has to be checked by any contributor. If finally not needed, then the line for the module should be on the migration issue, but it should be crossed out by any of the maintainers, explaining the reason why it's not needed.

But what I am searching is the functionality that the dms_attachment_link module provides in v15 for Odoo 16. That is, being able to select a file that is in DMS as an attachment to chatter, email, SMS etc especially in sales and CRM so we can send clients information that is frequently requested.

Will there be any way to do that in 16?

Seems to have been done here, but a step is still missing for it to be integrated #311 (comment)

@CarlosRoca13
Copy link

Working on dms_field

@fanchlegal
Copy link

@CarlosRoca13 : Do you need some help to do it ?

@CarlosRoca13
Copy link

Thanks @fanchlegal, I will try to have it between this or next week, if I need some help I will ask you

@fanchlegal
Copy link

@CarlosRoca13 : You're welcome, do not hesitate !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests