[UPD] delivery_deliverea: Update error message displayed #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsofl
force-pushed
the
16.0-upd_delivery_deliverea
branch
from
93f954a to
801cb5b
Compare
rousseldenis
requested changes
Dec 10, 2024
| if error.get("carrierCode") | ||
| else "", | ||
| } | ||
| _("%s") |
There was a problem hiding this comment.
Do you plan to translate every response ?
Nevertheless, you should use translation function arguments instead.
There was a problem hiding this comment.
You are right! Besides, the messages in response are already translated into Spanish (in my case), so it is not necessary to transalate one by one each message.
Thanks!
dalonsofl
force-pushed
the
16.0-upd_delivery_deliverea
branch
from
801cb5b to
ac96069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
delivery_deliverea
Describe the situation
Update the error display to only show the error returned by Deliverea instead of showing all errors in the response.
Affected versions:
16.0