Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exclusion instead of inclusion in shadowJar #345

Open
vorburger opened this issue Apr 8, 2022 · 0 comments
Open

Use exclusion instead of inclusion in shadowJar #345

vorburger opened this issue Apr 8, 2022 · 0 comments
Assignees

Comments

@vorburger
Copy link
Member

It would probably be preferable to use exclusion instead of inclusion in shadowJar.

Instead of exclude, dependencies exclude is probably what we would want.

A first attempt I did that caused:

java.lang.IllegalArgumentException: null
        at org.objectweb.asm.ClassReader.<init>(Unknown Source) ~[spongevanilla-1.12.2-7.3.1-RC391.jar:1.12.2-7.3.1-RC391]
        at org.objectweb.asm.ClassReader.<init>(Unknown Source) ~[spongevanilla-1.12.2-7.3.1-RC391.jar:1.12.2-7.3.1-RC391]
        at org.objectweb.asm.ClassReader.<init>(Unknown Source) ~[spongevanilla-1.12.2-7.3.1-RC391.jar:1.12.2-7.3.1-RC391]
        at org.spongepowered.server.launch.plugin.PluginScanner.scanClassFile(PluginScanner.java:341) ~[spongevanilla-1.12.2-7.3.1-RC391.jar:1.12.2-7.3.1-RC391]

which seems to mean a Java >1.8 JAR snuck in.

The best way to do is probably to compare the Web fat JAR currently built with the one built with a change for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant