From bc530f981ef4b0c48031e0338eabd3eb1fbca422 Mon Sep 17 00:00:00 2001
From: Matt Erickson <matt.erickson@auth0.com>
Date: Fri, 12 Mar 2021 13:27:00 -0600
Subject: [PATCH] Missing some cleanup of msg sends

---
 package-lock.json |  2 +-
 package.json      |  2 +-
 src/plusplus.js   | 35 +++++++++++++++--------------------
 3 files changed, 17 insertions(+), 22 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 7f2f0a6..914e849 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "hubot-plusplus-expanded",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/package.json b/package.json
index 6b45824..d32a063 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hubot-plusplus-expanded",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "A hubot script for micro praise",
   "main": "index.js",
   "engines": {
diff --git a/src/plusplus.js b/src/plusplus.js
index 2efb10d..05ef217 100644
--- a/src/plusplus.js
+++ b/src/plusplus.js
@@ -194,38 +194,33 @@ module.exports = function plusPlus(robot) {
   }
 
   function tellHowMuchPointsAreWorth(msg) {
-    msg.send("getting the quote");
     const promises = [];
     promises.push(
       axios({
         url: 'https://www.marketwatch.com/investing/stock/okta',
-        transformResponse: [data => {
+        transformResponse: [(data) => {
           const startIndex = data.indexOf('<meta name="price" content="');
           const oktaStockQuota = data.substring(startIndex + 28, startIndex + 35);
           return oktaStockQuota;
-        }]
-      }).then(response => {
-        return response.data;
-      })
+        }],
+      }).then((response) => response.data),
     );
     promises.push(
       axios({
         url: 'https://api.coindesk.com/v1/bpi/currentprice/ARS.json'
-      }).then(resp => {
-      const bitcoin = resp.data.bpi.USD.rate_float;
-      const ars = resp.data.bpi.ARS.rate_float;
-      const satoshi = bitcoin / 1e8;
-      return { bitcoin, ars, satoshi };
-      })
+      }).then((resp) => {
+        const bitcoin = resp.data.bpi.USD.rate_float;
+        const ars = resp.data.bpi.ARS.rate_float;
+        const satoshi = bitcoin / 1e8;
+        return { bitcoin, ars, satoshi };
+      }),
     );
-      
-    Promise.all(promises).then(promise => {
-      // eslint-disable-next-line
-      return msg.send(`A bitcoin is worth ${promise[1].bitcoin} USD right now (${promise[1].ars} ARS), a satoshi is about ${promise[1].satoshi}, Okta is worth ${promise[0]}, and ${msg.message._robot_name} points are worth nothing!`);
-    }).catch(err => {
-      msg.send(err);
-      return msg.send(`Seems like we are having trouble getting some data... Don\'t worry, though, your ${msg.message._robot_name} points are still worth nothing!`);
-    });
+
+    Promise.all(promises).then((promise) => msg.send(
+      // eslint-disable-next-line no-underscore-dangle
+      `A bitcoin is worth ${promise[1].bitcoin} USD right now (${promise[1].ars} ARS), a satoshi is about ${promise[1].satoshi}, Okta is worth ${promise[0]}, and ${msg.message._robot_name} points are worth nothing!`
+    // eslint-disable-next-line no-underscore-dangle
+    )).catch(() => msg.send(`Seems like we are having trouble getting some data... Don't worry, though, your ${msg.message._robot_name} points are still worth nothing!`));
   }
 
   async function respondWithLeaderLoserBoard(msg) {