From 62e137e908a9cc08fb1fbebe16196b633444ccec Mon Sep 17 00:00:00 2001
From: Matthew O'Keefe <matt@okeefe.dev>
Date: Fri, 4 Jun 2021 13:49:20 -0500
Subject: [PATCH] Updating give points logic

---
 package-lock.json        | 2 +-
 package.json             | 2 +-
 src/services/database.js | 7 ++++---
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index cab2502..a7e40e2 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "hubot-plusplus-expanded",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/package.json b/package.json
index f388d26..e306135 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hubot-plusplus-expanded",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "A hubot script for micro praise",
   "main": "index.js",
   "engines": {
diff --git a/src/services/database.js b/src/services/database.js
index 816cd0e..facdd34 100644
--- a/src/services/database.js
+++ b/src/services/database.js
@@ -134,7 +134,8 @@ class DatabaseService {
     const fromUser = await this.getUser(from.name);
 
     const oldScore = fromUser.pointsGiven[cleanName] ? fromUser.pointsGiven[cleanName] : 0;
-    fromUser.pointsGiven[cleanName] = (oldScore + score);
+    // even if they are down voting them they should still get a tally as they ++/-- the same person
+    fromUser.pointsGiven[cleanName] = (oldScore + 1);
     const result = await db.collection(scoresDocumentName)
       .findOneAndUpdate(
         { name: fromUser.name },
@@ -147,8 +148,8 @@ class DatabaseService {
       );
     const updatedUser = result.value;
 
-    if (updatedUser.pointsGiven[cleanName] % this.furtherFeedbackScore === 0 && score === 1) {
-      this.robot.logger.debug(`${from.name} has sent a lot of points to ${to.name} suggesting further feedback`);
+    if (updatedUser.pointsGiven[cleanName] % this.furtherFeedbackScore === 0) {
+      this.robot.logger.debug(`${from.name} has sent a lot of points to ${to.name} suggesting further feedback ${score}`);
       this.robot.messageRoom(from.id, `Looks like you've given ${to.name} quite a few points, maybe you should look at submitting ${this.peerFeedbackUrl}`);
     }
   }