File tree Expand file tree Collapse file tree 7 files changed +30
-12
lines changed
main/java/io/github/numichi/reactive/logger
test/java/io/github/numichi/reactive/logger Expand file tree Collapse file tree 7 files changed +30
-12
lines changed Original file line number Diff line number Diff line change @@ -40,8 +40,18 @@ abstract class ACoroutine<T : IReactorLogger>(
40
40
return this
41
41
}
42
42
43
- fun withEnableError (enableError : Boolean ): Builder <E , L , R > {
44
- this .enableError = enableError
43
+ @Deprecated(
44
+ message = " It can be misleading due to enabling word in method name and boolean parameter. Use: withError(boolean); False by default" ,
45
+ replaceWith = ReplaceWith (" withError(enable)" ),
46
+ level = DeprecationLevel .WARNING
47
+ )
48
+ fun withEnableError (enable : Boolean ): Builder <E , L , R > {
49
+ this .enableError = enable
50
+ return this
51
+ }
52
+
53
+ fun withError (enable : Boolean = true): Builder <E , L , R > {
54
+ this .enableError = enable
45
55
return this
46
56
}
47
57
Original file line number Diff line number Diff line change @@ -28,9 +28,19 @@ abstract class AReactive(
28
28
return this ;
29
29
}
30
30
31
- fun withEnableError (enableError : Boolean ): Builder <L , R > {
32
- this .enableError = enableError
33
- return this ;
31
+ @Deprecated(
32
+ message = " It can be misleading due to enabling word in method name and boolean parameter. Use: withError(boolean); False by default" ,
33
+ replaceWith = ReplaceWith (" withError(enableError)" ),
34
+ level = DeprecationLevel .WARNING
35
+ )
36
+ fun withEnableError (enable : Boolean ): Builder <L , R > {
37
+ this .enableError = enable
38
+ return this
39
+ }
40
+
41
+ fun withError (enable : Boolean = true): Builder <L , R > {
42
+ this .enableError = enable
43
+ return this
34
44
}
35
45
36
46
fun withLogger (logger : L ): Builder <L , R > {
Original file line number Diff line number Diff line change @@ -33,7 +33,7 @@ internal class CoroutineKLoggerTest {
33
33
private val imperativeLogger: KLogger = mockk(relaxed = true )
34
34
private val logger: ICoroutineKLogger = CoroutineKLogger .reactorBuilder().withLogger(imperativeLogger).build()
35
35
private val loggerScheduled: ICoroutineKLogger = CoroutineKLogger .reactorBuilder().withLogger(imperativeLogger).withScheduler(Schedulers .parallel()).build()
36
- private val loggerWithError: ICoroutineKLogger = CoroutineKLogger .reactorBuilder().withLogger(imperativeLogger).withEnableError( true ).build()
36
+ private val loggerWithError: ICoroutineKLogger = CoroutineKLogger .reactorBuilder().withLogger(imperativeLogger).withError( ).build()
37
37
38
38
companion object {
39
39
@JvmStatic
Original file line number Diff line number Diff line change @@ -32,7 +32,7 @@ internal class CoroutineLoggerTest {
32
32
private val imperativeLogger: Logger = mockk(relaxed = true )
33
33
private val logger = CoroutineLogger .reactorBuilder().withLogger(imperativeLogger).build()
34
34
private val loggerScheduled = CoroutineLogger .reactorBuilder().withLogger(imperativeLogger).withScheduler(Schedulers .parallel()).build()
35
- private val loggerWithError = CoroutineLogger .reactorBuilder().withLogger(imperativeLogger).withEnableError (true ).build()
35
+ private val loggerWithError = CoroutineLogger .reactorBuilder().withLogger(imperativeLogger).withError (true ).build()
36
36
37
37
companion object {
38
38
@JvmStatic
Original file line number Diff line number Diff line change @@ -30,7 +30,6 @@ internal class CoroutineOtherTest {
30
30
.withContextKey(ReactorContext )
31
31
.withContextExtractive { coroutineContext[it]?.context }
32
32
.withScheduler(Schedulers .boundedElastic())
33
- .withEnableError(false )
34
33
.withMDCContextKey(" other-key" )
35
34
.withLogger(mockKLogger)
36
35
.build()
@@ -45,7 +44,6 @@ internal class CoroutineOtherTest {
45
44
.withContextKey(ReactorContext )
46
45
.withContextExtractive { coroutineContext[it]?.context }
47
46
.withScheduler(Schedulers .boundedElastic())
48
- .withEnableError(false )
49
47
.withMDCContextKey(" other-key" )
50
48
.withLogger(mockLogger)
51
49
.build()
@@ -181,7 +179,7 @@ internal class CoroutineOtherTest {
181
179
@Test
182
180
fun `should throw exception from snapshot` () {
183
181
val logger = CoroutineLogger .reactorBuilder()
184
- .withEnableError (true )
182
+ .withError (true )
185
183
.withLogger(mockk(relaxed = true ))
186
184
.build()
187
185
Original file line number Diff line number Diff line change @@ -37,7 +37,7 @@ import java.util.*
37
37
internal class ReactiveKLoggerTest {
38
38
private val imperativeLogger: KLogger = mockk(relaxed = true )
39
39
private val logger = builder().withLogger(imperativeLogger).build()
40
- private val loggerWithError = builder().withLogger(imperativeLogger).withEnableError( true ).build()
40
+ private val loggerWithError = builder().withLogger(imperativeLogger).withError( ).build()
41
41
42
42
companion object {
43
43
fun randomText (): String {
Original file line number Diff line number Diff line change @@ -36,7 +36,7 @@ import java.util.*
36
36
internal class ReactiveLoggerTest {
37
37
private val imperativeLogger: Logger = mockk(relaxed = true )
38
38
private val logger = builder().withLogger(imperativeLogger).build()
39
- private val loggerWithError = builder().withLogger(imperativeLogger).withEnableError( true ).build()
39
+ private val loggerWithError = builder().withLogger(imperativeLogger).withError( ).build()
40
40
41
41
companion object {
42
42
fun randomText (): String {
You can’t perform that action at this time.
0 commit comments