test: remove unneeded clear since we take the err already

Author: dndll

crates/da-rpc-sys/src/lib.rs

@@ -55,6 +55,16 @@ pub extern "C" fn get_error() -> *mut c_char {
     }
 }
 
+/// # Safety
+/// We check if the pointers are null
+/// This is only used in a test
+#[no_mangle]
+pub unsafe extern "C" fn set_error(err: *const c_char) {
+    null_pointer_check!(err);
+    let msg = FfiStr::from_raw(err).into_string();
+    ffi_helpers::error_handling::update_last_error(anyhow::anyhow!(msg));
+}
+
 #[no_mangle]
 pub extern "C" fn clear_error() {
     ffi_helpers::error_handling::clear_last_error();

gopkg/da-rpc/near.go

@@ -238,8 +238,6 @@ func GetDAError() (err error) {
 	if errData != nil {
 		defer C.free(unsafe.Pointer(errData))
 
-                C.clear_error()
-		
 		errStr := C.GoString(errData)
 		return fmt.Errorf("NEAR DA client %s", errStr)
 	} else {

gopkg/da-rpc/near_test.go

@@ -162,7 +162,6 @@ func TestTo32Bytes(t *testing.T) {
 
 func TestGetDAError(t *testing.T) {
 	// Test error case
-	// TODO: Mock the C.get_error function to return an error
 	near.TestSetError("test error")
 	err := near.GetDAError()
 	assert.Error(t, err)