Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The website hangs sometimes #36

Open
swedebugia opened this issue May 4, 2020 · 17 comments
Open

The website hangs sometimes #36

swedebugia opened this issue May 4, 2020 · 17 comments
Labels
question Further information is requested

Comments

@swedebugia
Copy link
Contributor

I find that it suddenly becomes unresponsive. Reloads does not help. Closing the tab and reopening seems to help.

@Nudin
Copy link
Owner

Nudin commented May 9, 2020

When this happens, can you take a look at the browser console and page any errors/warnings here?

@swedebugia
Copy link
Contributor Author

Will do 👍

@Daniel-Mietchen
Copy link

It just happened to me, and I got

TypeError: newLangStr is null

Screenshot attached. At that point, I also noticed that the about two dozen or so lexemes I had curated before that one did not result in any edits.
Screen Shot 2020-05-18 at 05 51 57

@Daniel-Mietchen
Copy link

Update: the above-mentioned edits came in with about an hour of delay (sample edit matching the screenshot above). Not sure what caused that — has the webservice been restarted?

@Nudin
Copy link
Owner

Nudin commented May 19, 2020

  1. I found and fixed the bug that caused the TypeError you saw. That was triggered when one clicks the other languages button and then cancel in the dialog. Fixed it, but that should not cause the tool to become unresponsive.

  2. The edits that only were saved after an hour: The backend that creates the edit on Wikidata has a mechanism that edits won't be done if the server is already under high load. The parameter when this happens maxlag was set to the prescribed value for bots. Since this isn't a bot I can set is considerably higher. I just did that (from 5 to 18), so this behavior should only occur in rare cases when the servers of wikidata are extremely overused. But this again should not cause the site to become unresponsive.

Do you remember what the last action was before the site went unresponsive? And how is does this unresponsiveness become visible (only the tree man-buttons don't work or do the lanuage chooser also not work anymore)?

@Daniel-Mietchen
Copy link

Ad 1: thanks.
Ad 2: makes sense.

On topic: I just gave it another try, and it took much longer than (recently) usual to get to the point when it froze. Nothing to see in terms of error messages, but the three main buttons became unresponsive, while the language selector and the other links seem to work normally. The last thing I did before the freeze was fixing the Korean gloss in the tool and the corresponding description on-wiki. However, have made similar edits on other lexemes in the same session, with no issues.

Screen Shot 2020-05-19 at 18 51 21

@Daniel-Mietchen
Copy link

Examples of lexemes where similar edits did not cause issues: Amboss, Biosphäre.

@Daniel-Mietchen
Copy link

Just had it freeze once more, again after having edited the description on-wiki and the lexeme's gloss in the tool, though this time, it froze on the next lexeme, again with no error messages.

Screen Shot 2020-05-19 at 19 29 19

As a workaround, I am opening the language selector and adding/ removing some text string (e.g. "simple", "test"), which revives the tool.

@Nudin
Copy link
Owner

Nudin commented May 20, 2020

I found and fixed one thing that could have been the cause. Also, I added a debug-function. In the web-console you can call it with main.debug(), it prints all the state of the tool. If the bug (or other bugs) occurs toggle open the first level of the printed objects send me it's output.

@Nudin
Copy link
Owner

Nudin commented May 22, 2020

Has anyone noticed another freeze since my last post? If so, please reopen!

@Nudin Nudin closed this as completed May 22, 2020
@Daniel-Mietchen
Copy link

I can't reopen but noticed another freeze and tried to get the debug output that you mentioned above.

Screen Shot 2020-05-24 at 18 07 56

Screenshot_2020-05-24 MachtSinn – Das macht doch alles keinen Sinn (1)

Interestingly, while in debug mode, the buttons became active again. Leaving debug mode, they were frozen again, but going back to debug mode again, I could actually trigger the two expected edits.

Of note, the "No match" button seemed somewhat reactive even when the others were frozen, i.e. it sometimes displayed the tooltip "Press 'n'" but did not turn blue.

@Daniel-Mietchen
Copy link

I also noticed some minutes earlier that I had the Lebensmittel example from one of the comments above again, and while it did not freeze, it did not result in edits either, even though edits to multiple other lexeme pages worked as expected.
Can't go back to the logs for that because they were apparently restarted when I switched the target language to Korean.

@Nudin Nudin reopened this May 25, 2020
@Nudin
Copy link
Owner

Nudin commented May 25, 2020

I now found this in the logs:
"As an anti-abuse measure, you are limited from performing this action too many times in a short space of time, and you have exceeded this limit. Please try again in a few minutes."

Apparently you were editing too much too fast. ;) I'll ask on the tech mailing list, if there is anything I can do about this. I'll also add an error message to the Interface for these cases.

I am however now sure is that is the reason for the freezing or "just another" issue.

@Daniel-Mietchen
Copy link

This makes sense. I often have QuickStatements running in the background, which then results in (some) manual edits failing with such error messages, or tools (sometimes) failing without notice.

@Daniel-Mietchen
Copy link

I just got this warning:

19:10:33.221 load() 3 machtsinn.js:71:13
19:12:18.807 Source map error: Error: NetworkError when attempting to fetch resource.
Resource URL: moz-extension://257197c5-48c9-8d48-9f5b-b1fcc6b051d8/browser-polyfill.js
Source Map URL: browser-polyfill.js.map 

along with a "Learn more" link pointing to https://developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors .

This seems like a good candidate for causing a hang.

Interestingly, the simple act of opening the JS browser console made the buttons accessible again, as mentioned in previous comments.

As an aside, I think some more information on when to press "no match" would be useful. Here, the lexeme in question is das Tag, whereas all suggestions are a good match for one sense of der Tag. So far, I have usually skipped in such situations, but could imagine that indicating "no match" would be the better way to go. Note that the same example already came up at another ticket, and one benefit of indicating "no match" would presumably be no to run into the same suggestions time and again.
Screen Shot 2020-05-30 at 19 25 38

@Daniel-Mietchen
Copy link

When I clicked "Skip", I got this:
Screen Shot 2020-05-30 at 19 37 32

@Nudin
Copy link
Owner

Nudin commented May 31, 2020

I just got this warning:

19:12:18.807 Source map error: Error: NetworkError when attempting to fetch resource.
Resource URL: moz-extension://257197c5-48c9-8d48-9f5b-b1fcc6b051d8/browser-polyfill.js
Source Map URL: browser-polyfill.js.map 

This is clearly a bug in one of your browser extensions (moz-extension). You can go to about:debugging and see the tab 'this firefox' to see which extension has the id visible in the error.

Interestingly, the simple act of opening the JS browser console made the buttons accessible again, as mentioned in previous comments.

This also strongly suggests that it's something with the browser or an extension.
In your last screenshot you accidentally(?) enabled the option "Pause on exceptions" – sadly the exception isn't visible in the screenshot.

As an aside, I think some more information on when to press "no match" would be useful. Here, the lexeme in question is das Tag, whereas all suggestions are a good match for one sense of der Tag. So far, I have usually skipped in such situations, but could imagine that indicating "no match" would be the better way to go. Note that the same example already came up at another ticket, and one benefit of indicating "no match" would presumably be no to run into the same suggestions time and again.

I don't understand you here. The "reject match" does already exist for cases like this. While on 'skip' let the match will remain in the system and presented to users again, reject marks the match as wrong and it's never shown again. Why would you not press reject on such a wrong match?

@Nudin Nudin added the question Further information is requested label Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants