Add a parameter to disable reloading

Author: Aeltumn

interfaces/src/main/kotlin/com/noxcrew/interfaces/interfaces/ChestInterface.kt

@@ -24,9 +24,9 @@ public class ChestInterface internal constructor(
 
     override fun createPane(): Pane = Pane()
 
-    override suspend fun open(player: Player, parent: InterfaceView?): ChestInterfaceView {
+    override suspend fun open(player: Player, parent: InterfaceView?, reload: Boolean): ChestInterfaceView {
         val view = ChestInterfaceView(player, this, parent)
-        view.open()
+        view.open(reload)
         return view
     }
 }

interfaces/src/main/kotlin/com/noxcrew/interfaces/interfaces/CombinedInterface.kt

@@ -19,9 +19,9 @@ public class CombinedInterface internal constructor(
 
     override fun createPane(): CombinedPane = CombinedPane(rows)
 
-    override suspend fun open(player: Player, parent: InterfaceView?): CombinedInterfaceView {
+    override suspend fun open(player: Player, parent: InterfaceView?, reload: Boolean): CombinedInterfaceView {
         val view = CombinedInterfaceView(player, this, parent)
-        view.open()
+        view.open(reload)
         return view
     }
 }

interfaces/src/main/kotlin/com/noxcrew/interfaces/interfaces/Interface.kt

@@ -33,7 +33,8 @@ public interface Interface<I : Interface<I, P>, P : Pane> {
     public suspend fun open(
         player: Player,
         parent: InterfaceView? =
-            InterfacesListeners.INSTANCE.convertHolderToInterfaceView(player.openInventory.topInventory.getHolder(false))
+            InterfacesListeners.INSTANCE.convertHolderToInterfaceView(player.openInventory.topInventory.getHolder(false)),
+        reload: Boolean = true,
     ): InterfaceView
 
     /** Returns the [gridPoint] relative to the player's inventory within this inventory. */

interfaces/src/main/kotlin/com/noxcrew/interfaces/interfaces/PlayerInterface.kt

@@ -23,9 +23,9 @@ public class PlayerInterface internal constructor(
 
     override fun createPane(): PlayerPane = PlayerPane()
 
-    override suspend fun open(player: Player, parent: InterfaceView?): PlayerInterfaceView {
+    override suspend fun open(player: Player, parent: InterfaceView?, reload: Boolean): PlayerInterfaceView {
         val view = PlayerInterfaceView(player, this)
-        view.open()
+        view.open(reload)
         return view
     }
 }

interfaces/src/main/kotlin/com/noxcrew/interfaces/menu/BaseInventoryMenu.kt

@@ -16,10 +16,11 @@ public interface BaseInventoryMenu {
         player: Player,
         parent: InterfaceView? =
             InterfacesListeners.INSTANCE.convertHolderToInterfaceView(player.openInventory.topInventory.getHolder(false)),
+        reload: Boolean = true,
     ): InterfaceView?
 
     /** Opens a rendered [menu] for the given [player]. */
-    public suspend fun open(player: Player, parent: InterfaceView?, menu: Interface<*, *>): InterfaceView? {
+    public suspend fun open(player: Player, parent: InterfaceView?, menu: Interface<*, *>, reload: Boolean = true): InterfaceView? {
         // Quit if the coroutine is no longer active
         if (!coroutineContext.isActive) return null
 
@@ -31,6 +32,6 @@ public interface BaseInventoryMenu {
         if (parent?.isTreeOpened == false) return null
 
         // Finally open the actual menu!
-        return menu.open(player, parent)
+        return menu.open(player, parent, reload)
     }
 }

interfaces/src/main/kotlin/com/noxcrew/interfaces/menu/PlayerInventoryMenu.kt

@@ -25,14 +25,14 @@ public abstract class PlayerInventoryMenu : BaseInventoryMenu {
         configure(player)
     }
 
-    override suspend fun open(player: Player, parent: InterfaceView?): PlayerInterfaceView? {
+    override suspend fun open(player: Player, parent: InterfaceView?, reload: Boolean): PlayerInterfaceView? {
         val menu = exceptionHandler.execute(
             InterfacesExceptionContext(
                 player,
                 InterfacesOperation.BUILDING_PLAYER,
                 null,
             ),
         ) { buildMenu(player) } ?: return null
-        return open(player, parent, menu) as PlayerInterfaceView
+        return open(player, parent, menu, reload) as PlayerInterfaceView
     }
 }

interfaces/src/main/kotlin/com/noxcrew/interfaces/menu/SimpleInventoryMenu.kt

@@ -21,7 +21,7 @@ public abstract class SimpleInventoryMenu<B : InterfaceBuilder<out Pane, *>> : B
     /** Configures the GUI for the given [player]. */
     protected abstract suspend fun B.configure(player: Player)
 
-    override suspend fun open(player: Player, parent: InterfaceView?): InterfaceView? {
+    override suspend fun open(player: Player, parent: InterfaceView?, reload: Boolean): InterfaceView? {
         val menu = exceptionHandler.execute(
             InterfacesExceptionContext(
                 player,
@@ -35,6 +35,6 @@ public abstract class SimpleInventoryMenu<B : InterfaceBuilder<out Pane, *>> : B
             }
         } ?: return null
 
-        return open(player, parent, menu)
+        return open(player, parent, menu, reload)
     }
 }

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/AbstractInterfaceView.kt

@@ -92,6 +92,9 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
     /** Whether the title of the inventory should be re-painted. */
     protected var refreshTitle: Boolean = true
 
+    /** Whether all properties should be fully reloaded. */
+    protected var fullyReload: Boolean = false
+
     /** Whether a click is being processed. */
     public var isProcessingClick: Boolean = false
 
@@ -269,7 +272,7 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
         applyTransforms(builder.transforms, initial = true, renderIfEmpty = true)
     }
 
-    override suspend fun reopen(newParent: InterfaceView?): Boolean {
+    override suspend fun reopen(newParent: InterfaceView?, reload: Boolean): Boolean {
         // The player has since disconnected, close the menu properly!
         if (Bukkit.isStopping() || !player.isConnected) {
             if (shouldStillBeOpened) {
@@ -291,11 +294,11 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
         if (newParent != null) {
             parent = newParent
         }
-        open()
+        open(reload)
         return true
     }
 
-    override suspend fun open() {
+    override suspend fun open(reload: Boolean) {
         // Don't open an interface for an offline player
         if (!player.isConnected || !coroutineContext.isActive) return
 
@@ -308,6 +311,12 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
         openIfClosed.set(true)
         shouldBeOpened.set(true)
 
+        // Only fully re-evaluate all properties if this menu wants to, or if this menu is the first
+        // in a chain (parent is not there or this is the first non-player interface)
+        if (reload && (builder.alwaysReloadProperties || parent == null || parent is PlayerInterfaceView)) {
+            fullyReload = true
+        }
+
         // If we want to redraw the title we use a new inventory always
         if (backing.builder.redrawTitleOnReopen) {
             refreshTitle = true
@@ -337,7 +346,7 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
         if (parent == null) {
             close()
         } else {
-            parent.open()
+            parent.open(reload = false)
         }
     }
 
@@ -352,10 +361,6 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
                     this,
                 ),
             ) {
-                // Only fully re-evaluate all properties if this menu wants to, or if this menu is the first
-                // in a chain (parent is not there or this is the first non-player interface)
-                val fullyReload = builder.alwaysReloadProperties || parent == null || parent is PlayerInterfaceView
-
                 // Run the initialize method on any state properties to refresh them,
                 // ensure we only refresh every property once even if we need it multiple
                 // times!
@@ -379,6 +384,9 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
                         }
                     }
                 }
+
+                // Mark that we have done a reload
+                fullyReload = false
             }
         } finally {
             queueAllTriggers.set(false)

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/InterfaceView.kt

@@ -34,7 +34,7 @@ public interface InterfaceView {
     public val isTreeOpened: Boolean
 
     /** Opens up this view. */
-    public suspend fun open()
+    public suspend fun open(reload: Boolean = true)
 
     /** Re-opens only if this menu should still be. */
     public suspend fun reopenIfIntended(): Boolean {
@@ -51,6 +51,7 @@ public interface InterfaceView {
     public suspend fun reopen(
         newParent: InterfaceView? =
             InterfacesListeners.INSTANCE.convertHolderToInterfaceView(player.openInventory.topInventory.getHolder(false)),
+        reload: Boolean = true,
     ): Boolean
 
     /** Closes this view. */