Only reload properties for root menus

This is a much safer optimization that does apply in many cases and doesn't require implementations to fully rewrite around the new structure

Author: Aeltumn

interfaces/src/main/kotlin/com/noxcrew/interfaces/interfaces/InterfaceProperties.kt

@@ -46,6 +46,9 @@ public open class InterfaceProperties<P : Pane> {
     /** Whether clicking on empty slots should be cancelled. */
     public var preventClickingEmptySlots: Boolean = true
 
+    /** If `true`, lazy and state properties are always re-evaluated instead of only initialized. */
+    public var alwaysReloadProperties: Boolean = false
+
     /**
      * Whether the player's own inventory should be editable if [preventClickingEmptySlots] is `true`. Only allowed for
      * [ChestInterfaceBuilder].

interfaces/src/main/kotlin/com/noxcrew/interfaces/properties/LazyProperty.kt

@@ -28,6 +28,7 @@ public abstract class LazyProperty<T : Any>(
     private var updateJob: Deferred<Unit>? = null
     private var triggeringUpdate = false
     private var lastRefresh: Instant = Instant.MIN
+    private var initialized: Boolean = false
 
     /** A simple lazy property backed by [block]. */
     public class Simple<T : Any>(
@@ -50,6 +51,13 @@ public abstract class LazyProperty<T : Any>(
     /** Loads the value of this property. */
     public abstract suspend fun load(reload: Boolean = true): T
 
+    /** Initializes this property if it hasn't already. */
+    public suspend fun initialize(view: InterfaceView? = null) {
+        if (!initialized || value == null) {
+            reevaluate(reload = !initialized, view = view)
+        }
+    }
+
     /**
      * Triggers a re-evaluation of the property.
      * If [reload] is given, all data should be fully reloaded.
@@ -92,6 +100,7 @@ public abstract class LazyProperty<T : Any>(
                     }
                 }
             }
+            initialized = true
             lastRefresh = Instant.now()
             updateJob = null
         }

interfaces/src/main/kotlin/com/noxcrew/interfaces/properties/StateProperty.kt

@@ -39,9 +39,9 @@ public abstract class StateProperty(
     private var initialized: Boolean = false
 
     /** Initializes this property if it hasn't already. */
-    public suspend fun initialize() {
+    public suspend fun initialize(view: InterfaceView? = null) {
         if (!initialized) {
-            refresh()
+            refresh(view = view)
         }
     }
 

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/AbstractInterfaceView.kt

@@ -352,19 +352,31 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
                     this,
                 ),
             ) {
+                // Only fully re-evaluate all properties if this menu wants to, or if this menu is the first
+                // in a chain (parent is not there or this is the first non-player interface)
+                val fullyReload = builder.alwaysReloadProperties || parent == null || parent is PlayerInterfaceView
+
                 // Run the initialize method on any state properties to refresh them,
                 // ensure we only refresh every property once even if we need it multiple
                 // times!
                 builder.transforms.flatMap { it.triggers }.filterIsInstance<StateProperty>().distinct().forEach {
                     withTimeout(builder.defaultTimeout) {
-                        it.refresh(view = this@AbstractInterfaceView)
+                        if (fullyReload) {
+                            it.refresh(view = this@AbstractInterfaceView)
+                        } else {
+                            it.initialize(view = this@AbstractInterfaceView)
+                        }
                     }
                 }
 
                 // Also re-evaluate all lazy properties!
                 builder.transforms.flatMap { it.triggers }.filterIsInstance<LazyProperty<*>>().distinct().forEach {
                     withTimeout(builder.defaultTimeout) {
-                        it.reevaluate(view = this@AbstractInterfaceView)
+                        if (fullyReload) {
+                            it.reevaluate(view = this@AbstractInterfaceView)
+                        } else {
+                            it.initialize(view = this@AbstractInterfaceView)
+                        }
                     }
                 }
             }