Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts_ls: prevent from formatting #495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vagahbond
Copy link
Contributor

Prevent ts_ls from touching the formating.

ts_ls is supposed to be used as a lsp, and prettier as a formatter.

In the current situation, ts_ls has the last word over prettier and applies changes such as adding spaces between empty curled braces.

{} -> { }

With this PR, ts_ls is still enabled but is prevented from using formatting.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

prevent ts_ls from touching the formating.
@Vagahbond Vagahbond requested a review from NotAShelf as a code owner December 12, 2024 23:21
@NotAShelf NotAShelf requested a review from diniamo December 12, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants