Change set_dir and login functions to read DB credientals from enivorment variables.

[novica]

There is going to be a change in the login to PJS this weekend or next. That may be a nice time to change this. As far as I can see we only need to change a few things
Get the information into .Renvirion, that should be mostly done so that people don't have to type themselves.
Change NVIdb::set_dir_NVI
Change NVIdb::login (group of functions, but they are partly wrappers around one or two core functions. Probably one should create a "subfunction" to retrieve the data in .Renviron.

[novica]

The way we are going to do this is all changes are going to be made via a pull requests on the dev branch of the repository. From the dev branch we create additional branches, usually named after the issue (in this case I will create a branch called issue-28). I will implement the changes on that branch, then I will make a PR on dev. Once that is verified, the package maintener can merge dev into main. Right now there are no automatic checks set up, but this is something that can be done to make sure the new code doesn't crash something.

[PetterHopp]

Sorry Novica, I accidentally deleted the branch. I thought it was something else and didn't check. How much did you loose and do you have a copy of it?

[novica]

No worries Petter. All good. El mié, 24 ene 2024 a las 12:23, Petter Hopp ***@***.***>) escribió:

…

Sorry Novica, I accidentally deleted the branch. I thought it was something else and didn't check. How much did you loose and do you have a copy of it? — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABIOXC3RED632SU2QYYEVLYQDVKXAVCNFSM6AAAAAA4TDY4Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXHEZTIMJTHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- ≠

[PetterHopp]

Thanks. I will make a new directory with nearly the same name.