Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 feedback #84

Open
dartess opened this issue Dec 25, 2023 · 2 comments
Open

v3 feedback #84

dartess opened this issue Dec 25, 2023 · 2 comments

Comments

@dartess
Copy link

dartess commented Dec 25, 2023

hey
I noticed that an alpha of a new version had appeared and decided to try it

new api with

    const scrollContainer = useScrollContainer(options);
    return <div ref={scrollContainer.ref} />

not convenient if we need to have our own ref. in my case, I need to programmatically call a scroll on the container. To do this, I had to add a wrapper to the ref, which first installs my ref, then the library ref. A more universal solution would be to pass the ref as the first required argument.

I'm optimizing the bundle and, unfortunately, the weight of the bundle has increased with the new version. maybe something can be done about this?
react-indiana-drag-scroll v2 7,39KB
react-indiana-drag-scroll v3 10,54KB

@Norserium
Copy link
Owner

@dartess, thank you for your feedback, I appreciate it. But it needs time to investigate how to improve that aspects.

@ayuhito
Copy link

ayuhito commented Sep 7, 2024

Maybe the React 19 changes with ref makes this more simpler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants