Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing markdown styling #121

Open
damiensedgwick opened this issue Sep 9, 2022 · 3 comments
Open

Missing markdown styling #121

damiensedgwick opened this issue Sep 9, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@damiensedgwick
Copy link
Contributor

damiensedgwick commented Sep 9, 2022

When adding a new post and checking through it on local, I noticed that some syntax highlighting (right word?) is missing for text within single backticks, see image.

image

It would appear there is no styling for inline backticks. However, the html does appear to come through correctly:

<p>
  <code>.map()</code> Creates a new array which is populated with the results of calling a provided function on every element in the calling array.
</p>

In this instance, .map() should have different styles to show it is not just normal text and to behave as markdown would.

@damiensedgwick damiensedgwick added enhancement New feature or request good first issue Good for newcomers labels Sep 9, 2022
@pbnj1
Copy link

pbnj1 commented Sep 9, 2022

I would like to try to fix this..but honestly I am new and I don't know how to find it to fix it?

@damiensedgwick
Copy link
Contributor Author

damiensedgwick commented Sep 9, 2022

I would like to try to fix this..but honestly I am new and I don't know how to find it to fix it?

@pbnj1 I think the trick here will be using some specific css selectors to target the <code>...</code> elements within an article.

It would probably make sense to discuss how these should look first though.

@Illizian
Copy link
Member

Illizian commented Sep 9, 2022

Checkout typography.css, there's a selector for <code> as a direct descendant of .typography but not when within a <p>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants