NCD-660: Disable write button on click, enable on write finished #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cybic
added
the
doc required
cybic
force-pushed
the
NCD-660_feedback_on_write_config
branch
from
19f233b to
ce51941
Compare
cybic
force-pushed
the
NCD-660_feedback_on_write_config
branch
from
ce51941 to
54c2eab
Compare
src/SidePanel.tsx
Outdated
| @@ -21,22 +21,32 @@ import { getConfigArray } from './features/Configuration/boardControllerConfigSl | |||
| export default () => { | |||
| logger.debug('Rendering SidePanel'); | |||
|
|
|||
| const [isWriting, setWriting] = useState<boolean>(false); | |||
There was a problem hiding this comment.
note: Pretty sure typescript will infer the type here so no need to add it explicitly.
boundlesscalm
approved these changes
Jan 31, 2024
cybic
force-pushed
the
NCD-660_feedback_on_write_config
branch
from
54c2eab to
c991721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will tell users that we are writing the configuration to the DK, by greying the "Write config"-button on click. After the write is finished, we "re-enable" the button, indicating that the write is finished. (In addition to logging "Configuration written")