Add generated trait methods #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are implemented as explicit funtions, in addition deleted defaulted asignment operators and copy constructors, as they allowed illegal construction of objects leading to double frees Signed-off-by: Martynas Gurskas <[email protected]>
arg0d
approved these changes
Nov 30, 2023
Co-authored-by: Kristupas Antanavicius <[email protected]>
|
Fair point about name collisions, could rename the hash function to |
|
You can leave it as is, I'm just pointing out that we should be mindful about these auto generated names. I don't think its possible to avoid having auto generated names in all cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are implemented as explicit funtions, in addition deleted defaulted asignment operators and copy constructors, as they allowed illegal construction of objects leading to double frees